Add ameba #15875
Merged
Add ameba #15875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
infra/ameba
branch
from
d64279f to
e838118
Compare
Sija
suggested changes
Jun 12, 2025
ysbaddaden
approved these changes
Jun 13, 2025
$ ameba -r | tail -n1
Total rules: 77 / 45 enabled
$ ameba -v
1.6.4
$ ameba-master -r | tail -n1
Total rules: 101 / 58 enabled
$ ameba-master -v
1.7.0-dev |
Sija
reviewed
Jun 14, 2025
Comment on lines
+74
to
+77
| # BUG: https://github.com/crystal-ameba/ameba/issues/612 | ||
| Lint/TopLevelOperatorDefinition: | ||
| Enabled: false | ||
|
|
There was a problem hiding this comment.
This has been already fixed.
Suggested change
| # BUG: https://github.com/crystal-ameba/ameba/issues/612 | |
| Lint/TopLevelOperatorDefinition: | |
| Enabled: false |
Sija
reviewed
Jun 14, 2025
Comment on lines
+168
to
+171
| # BUG: https://github.com/crystal-ameba/ameba/issues/614 | ||
| Style/ParenthesesAroundCondition: | ||
| Enabled: false | ||
|
|
There was a problem hiding this comment.
ditto
Suggested change
| # BUG: https://github.com/crystal-ameba/ameba/issues/614 | |
| Style/ParenthesesAroundCondition: | |
| Enabled: false |
There was a problem hiding this comment.
The fix is only in master. Latest ameba release is still broken.
There are also still other violations of this rule. This is a TODO for a follow-up.
There was a problem hiding this comment.
Whole 1.7.0-dev is only in master, so... 🤷♂️
Sija
reviewed
Jun 14, 2025
Comment on lines
+48
to
+51
| Lint/LiteralInInterpolation: | ||
| Excluded: | ||
| - spec/std/random_spec.cr # BUG: https://github.com/crystal-ameba/ameba/issues/611 | ||
|
|
There was a problem hiding this comment.
That was just fixed and landed in master.
Suggested change
| Lint/LiteralInInterpolation: | |
| Excluded: | |
| - spec/std/random_spec.cr # BUG: https://github.com/crystal-ameba/ameba/issues/611 |
|
@Sija I'll merge this as is. The purpose of this PR is to setup a basic configuration. It's not meant to be the final word. Further changes just cause more delays, which creates friction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configuration and a CI job for https://github.com/crystal-ameba/ameba
I let ameba generate a config (
ameba --gen-config) but replaced all exclusions with hard disables. Then I fixed the violations for some of the rules, which have already been merged in the last couple of days. So I removed the disables for these rules.The configuration is annotated with explanations in code.
I have disabled most
NamingandStylerules because most had large numbers of violations and some of them seem questionable. We can consider enabling some of the in the future, piece by pieceFor review, it's best to ignore the first three commits and review the rest combined, not the individual commits.Depends on #15860, #15870Resolves #14608
Closes #14631