Replace is_a? calls with convenient alternatives
#15860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HertzDevil
approved these changes
May 31, 2025
straight-shoota
commented
May 31, 2025
| @@ -1099,7 +1099,7 @@ class Crystal::Repl::Compiler < Crystal::Visitor | |||
| end | |||
|
|
|||
| private def dispatch_class_var(owner : Type, metaclass : Bool, node : ASTNode, &) | |||
| types = owner.all_subclasses.select { |t| t.is_a?(ClassVarContainer) } | |||
| types = owner.all_subclasses.select(ClassVarContainer) | |||
There was a problem hiding this comment.
This is failing because types must be Array(Crystal::Type) because we also add owner to it.
But select(ClassVarContainer) would return Array(Crystal::ClassVarContainer).
It's probably best to refactor this a bit to make the typing more explicit.
Sija
reviewed
May 31, 2025
HertzDevil
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were discovered with ameba's
Style/IsAFilterandStyle/IsANilrules.