Added support for specifying custom models under all existing presets. #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpnota
approved these changes
Aug 11, 2020
|
Thanks for the contribution! The Travis CI issues seem to stem from some PyTorch changes, will fix on another branch. |
|
I just realized that this eventually got merged into the master in my fork and not in the upstream repository. That's not right, is it? Also, a word of appreciation: I've been working with this repo for a couple of days now, preparing some examples for my ML class, and I can't get over how clear and beautiful all the interfaces are. It's absolutely amazing. EDIT: Oh no, my mistake, obviously, on upstream it's in develop of course... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make it easier to use any of the existing presets with a custom model, I forwarded the model creation functions to the presets' interfaces as optional parameters. Default arguments ensure that the previous behaviour remains unchanged unless a custom model constructor is actually specified.