Skip to content

fix(search): fix visual glitch causing top bar to shrink during search #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

fix(search): fix visual glitch causing top bar to shrink during search #2336

merged 1 commit into from
Apr 7, 2025

Conversation

MrAnno
Copy link
Contributor

@MrAnno MrAnno commented Apr 5, 2025 •
edited
Loading

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description

This PR fixes a visual glitch where the top bar would shrink by a few pixels when using the search bar.

Fixes #2337

@MrAnno MrAnno marked this pull request as draft April 5, 2025 23:47
@MrAnno MrAnno force-pushed the fix-topbar-visual-glitch branch from d00b51f to cca1777 Compare April 6, 2025 00:16
@MrAnno MrAnno marked this pull request as ready for review April 6, 2025 00:17
cotes2020
cotes2020 reviewed Apr 6, 2025
View reviewed changes
Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what issue you're encountering—could you please describe it in detail? If possible, consider opening an issue.

@MrAnno
Copy link
Contributor Author

MrAnno commented Apr 6, 2025

Hi,

Sure, I've explained and recorded the behavior I experienced in #2337.

@cotes2020
Copy link
Owner

Sure, I've explained and recorded the behavior I experienced in #2337.

Thanks

cotes2020
cotes2020 requested changes Apr 7, 2025
View reviewed changes
Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jekyll-theme-chirpy/_includes/topbar.html

Line 3 in db40db6

<header id="topbar-wrapper" aria-label="Top Bar">

I think adding Bootstrap class to the HTML would be easier to maintain!

- <header id="topbar-wrapper" aria-label="Top Bar">
+ <header id="topbar-wrapper" class="flex-shrink-0" aria-label="Top Bar">

@MrAnno MrAnno force-pushed the fix-topbar-visual-glitch branch from cca1777 to 06c4f45 Compare April 7, 2025 08:52
@cotes2020 cotes2020 merged commit f744929 into cotes2020:master Apr 7, 2025
5 checks passed
bitwallke pushed a commit to bitwallke/bitwallke.github.io that referenced this pull request May 6, 2025
@MrAnno
fix: prevent the search bar from moving when focused (cotes2020#2336)
298bda2
github-actions bot pushed a commit that referenced this pull request May 18, 2025
@semantic-release-bot
chore(release): 7.3.0
53770e4 
## [7.3.0](v7.2.4...v7.3.0) (2025-05-18)

### Features

* **i18n:** add Catalan Spanish locale translation ([#2349](#2349)) ([167c98c](167c98c))
* **i18n:** add Dutch locale ([#2076](#2076)) ([981ddba](981ddba))
* **i18n:** add Japanese locale ([#2295](#2295)) ([571c90f](571c90f))
* **i18n:** add persian language ([#2238](#2238)) ([7d4d35c](7d4d35c))

### Bug Fixes

* avoid `mathjax` loading failure on page refresh ([#2389](#2389)) ([401e2af](401e2af))
* improve accuracy of moving `img` element classes ([#2399](#2399)) ([d0f8f95](d0f8f95))
* prevent the search bar from moving when focused ([#2336](#2336)) ([f744929](f744929))
* recognize global theme mode ([#2357](#2357)) ([7708adb](7708adb))
* **search:** avoid missing spaces between paragraphs in search results ([#2199](#2199)) ([0eb7efa](0eb7efa))
* **ui:** fix incomplete border color on hover for tags ([#2359](#2359)) ([c626447](c626447))

### Improvements

* **seo:** improve accessibility and aligns with best practices ([#2289](#2289)) ([54d4d59](54d4d59))
Datta0 added a commit to Datta0/datta0.github.io that referenced this pull request May 20, 2025
@Datta0
Squashed commit of the following:
05790fd 
commit 53770e4
Author: semantic-release-bot <[email protected]>
Date:   Sun May 18 13:17:30 2025 +0000

    chore(release): 7.3.0

    ## [7.3.0](cotes2020/jekyll-theme-chirpy@v7.2.4...v7.3.0) (2025-05-18)

    ### Features

    * **i18n:** add Catalan Spanish locale translation ([cotes2020#2349](cotes2020#2349)) ([167c98c](cotes2020@167c98c))
    * **i18n:** add Dutch locale ([cotes2020#2076](cotes2020#2076)) ([981ddba](cotes2020@981ddba))
    * **i18n:** add Japanese locale ([cotes2020#2295](cotes2020#2295)) ([571c90f](cotes2020@571c90f))
    * **i18n:** add persian language ([cotes2020#2238](cotes2020#2238)) ([7d4d35c](cotes2020@7d4d35c))

    ### Bug Fixes

    * avoid `mathjax` loading failure on page refresh ([cotes2020#2389](cotes2020#2389)) ([401e2af](cotes2020@401e2af))
    * improve accuracy of moving `img` element classes ([cotes2020#2399](cotes2020#2399)) ([d0f8f95](cotes2020@d0f8f95))
    * prevent the search bar from moving when focused ([cotes2020#2336](cotes2020#2336)) ([f744929](cotes2020@f744929))
    * recognize global theme mode ([cotes2020#2357](cotes2020#2357)) ([7708adb](cotes2020@7708adb))
    * **search:** avoid missing spaces between paragraphs in search results ([cotes2020#2199](cotes2020#2199)) ([0eb7efa](cotes2020@0eb7efa))
    * **ui:** fix incomplete border color on hover for tags ([cotes2020#2359](cotes2020#2359)) ([c626447](cotes2020@c626447))

    ### Improvements

    * **seo:** improve accessibility and aligns with best practices ([cotes2020#2289](cotes2020#2289)) ([54d4d59](cotes2020@54d4d59))

commit d84b727
Merge: 5e41d87 519e4f1
Author: Cotes Chung <[email protected]>
Date:   Sun May 18 21:16:09 2025 +0800

    Merge branch 'master' into production

commit 519e4f1
Author: Cotes Chung <[email protected]>
Date:   Sun May 18 21:14:56 2025 +0800

    chore: upgrade dependencies to the latest version (cotes2020#2409)

commit d0f8f95
Author: Cotes Chung <[email protected]>
Date:   Sun May 11 22:19:18 2025 +0800

    fix: improve accuracy of moving `img` element classes (cotes2020#2399)

commit 401e2af
Author: Cotes Chung <[email protected]>
Date:   Mon May 5 11:55:48 2025 +0800

    fix: avoid `mathjax` loading failure on page refresh (cotes2020#2389)

commit ada38aa
Author: Cotes Chung <[email protected]>
Date:   Mon May 5 11:15:08 2025 +0800

    chore: avoid auto-formatting liquid and sass mixed code

commit 61ae6cc
Author: Cotes Chung <[email protected]>
Date:   Mon May 5 11:14:07 2025 +0800

    chore(dev-deps): add eslint config file

commit 9f38a2d
Author: Cotes Chung <[email protected]>
Date:   Sat May 3 16:18:52 2025 +0800

    refactor: move the path of `theme.js`

commit 23d953c
Author: Cotes Chung <[email protected]>
Date:   Sat May 3 16:14:50 2025 +0800

    chore(deps): remove plugin `jekyll-redirect-from`

    Discussed in cotes2020#2313

commit b48ea68
Author: iSpeakNerd <[email protected]>
Date:   Thu Apr 24 05:25:46 2025 -0700

    chore: update `linkedin` sharing url (cotes2020#2307)

commit c626447
Author: László Várady <[email protected]>
Date:   Thu Apr 24 14:23:43 2025 +0200

    fix(ui): fix incomplete border color on hover for tags (cotes2020#2359)

commit 7708adb
Author: Cotes Chung <[email protected]>
Date:   Wed Apr 16 18:08:43 2025 +0800

    fix: recognize global theme mode (cotes2020#2357)

commit 167c98c
Author: Delyn Choong <[email protected]>
Date:   Sun Apr 13 22:16:47 2025 +0800

    feat(i18n): add Catalan Spanish locale translation (cotes2020#2349)

commit f744929
Author: László Várady <[email protected]>
Date:   Mon Apr 7 13:36:32 2025 +0200

    fix: prevent the search bar from moving when focused (cotes2020#2336)

commit db40db6
Author: Alejandro <[email protected]>
Date:   Sat Apr 5 01:28:29 2025 +0200

    chore: add parameter in `search-results.html` (cotes2020#2330)

commit 571c90f
Author: nakamura <[email protected]>
Date:   Sat Mar 29 04:54:54 2025 +0900

    feat(i18n): add Japanese locale (cotes2020#2295)

commit 54d4d59
Author: Türkalp Burak KAYRANCIOĞLU <[email protected]>
Date:   Sat Mar 8 17:24:47 2025 +0300

    perf(seo): improve accessibility and aligns with best practices (cotes2020#2289)

commit e315864
Author: Corey Goldberg <[email protected]>
Date:   Tue Mar 4 16:06:37 2025 -0500

    docs: fix typo in `2019-08-08-write-a-new-post.md` (cotes2020#2281)

    Signed-off-by: Corey Goldberg <[email protected]>

commit 7d4d35c
Author: MasihGhaznavi <[email protected]>
Date:   Sun Feb 9 09:58:39 2025 +0330

    feat(i18n): add persian language (cotes2020#2238)

commit 231956d
Author: algorithmic-parallels <[email protected]>
Date:   Thu Feb 6 00:27:54 2025 -0500

    docs: using long form Jekyll subcommand (cotes2020#2231)

Signed-off-by: datta0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cotes2020 cotes2020 cotes2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual glitch causing top bar to shrink during search
2 participants
@MrAnno @cotes2020