Skip to content

Update search-results.html #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

Update search-results.html #2330

merged 2 commits into from
Apr 4, 2025

Conversation

alazaroc
Copy link
Contributor

@alazaroc alazaroc commented Apr 1, 2025

Fix value of "trending_tags" text in multi-language in mobile

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description

The text for "trending_tags" was displaying incorrectly on mobile devices when using multi-language support.

@alazaroc
Update search-results.html
04b6ffe 
Fix value of "trending_tags" text in multi-language in mobile

Signed-off-by: Alejandro <[email protected]>
RlxChap2

This comment was marked as spam.

Sign in to view

cotes2020
cotes2020 reviewed Apr 2, 2025
View reviewed changes
Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that after modifying the lang in _config.yml, the Trending Tags did not change? If so, it seems that this issue does not exist.

@alazaroc
Copy link
Contributor Author

alazaroc commented Apr 2, 2025

Exactly @cotes2020. If I configure Spanish as my language in _config.yml and try to access the search on the mobile version (only on the mobile version), the English text is shown:
image

If you include the line that I put in this PR, this is fixed. This other image shows the fix:
image

Furthermore, all other HTML page inclusions utilize lang=lang, except for this particular file

@cotes2020
Copy link
Owner

cotes2020 commented Apr 3, 2025 •
edited
Loading

Sorry, I still can't reproduce the error you mentioned.

include_cached has already cached trending-tags.html in _layouts/default.html, so it's fine even if search-results.html doesn't specify lang.

jekyll-theme-chirpy/_layouts/default.html

Line 39 in 5e41d87

{% include_cached trending-tags.html lang=lang %}

Of course, for better consistency, adding the lang parameter in search-results.html wouldn't hurt.

@alazaroc
Copy link
Contributor Author

alazaroc commented Apr 3, 2025 •
edited
Loading

mmm, then this might be due to other modifications in my own version. I also have multi-language enabled (en/es). Never mind, I've already made the change on my end, the decision is yours

btw, thanks for your awesome work here!

cotes2020
cotes2020 requested changes Apr 3, 2025
View reviewed changes
@alazaroc @cotes2020
Update _includes/search-results.html
2b8e0a9 
Pass the parameter from the upper level

Co-authored-by: Cotes Chung <[email protected]>
Signed-off-by: Alejandro <[email protected]>
@cotes2020 cotes2020 merged commit db40db6 into cotes2020:master Apr 4, 2025
3 of 4 checks passed
@alazaroc alazaroc deleted the patch-1 branch April 5, 2025 08:18
bitwallke pushed a commit to bitwallke/bitwallke.github.io that referenced this pull request May 6, 2025
@alazaroc
chore: add parameter in search-results.html (cotes2020#2330)
ce57882
Datta0 added a commit to Datta0/datta0.github.io that referenced this pull request May 20, 2025
@Datta0
Squashed commit of the following:
05790fd 
commit 53770e4
Author: semantic-release-bot <[email protected]>
Date:   Sun May 18 13:17:30 2025 +0000

    chore(release): 7.3.0

    ## [7.3.0](cotes2020/jekyll-theme-chirpy@v7.2.4...v7.3.0) (2025-05-18)

    ### Features

    * **i18n:** add Catalan Spanish locale translation ([cotes2020#2349](cotes2020#2349)) ([167c98c](cotes2020@167c98c))
    * **i18n:** add Dutch locale ([cotes2020#2076](cotes2020#2076)) ([981ddba](cotes2020@981ddba))
    * **i18n:** add Japanese locale ([cotes2020#2295](cotes2020#2295)) ([571c90f](cotes2020@571c90f))
    * **i18n:** add persian language ([cotes2020#2238](cotes2020#2238)) ([7d4d35c](cotes2020@7d4d35c))

    ### Bug Fixes

    * avoid `mathjax` loading failure on page refresh ([cotes2020#2389](cotes2020#2389)) ([401e2af](cotes2020@401e2af))
    * improve accuracy of moving `img` element classes ([cotes2020#2399](cotes2020#2399)) ([d0f8f95](cotes2020@d0f8f95))
    * prevent the search bar from moving when focused ([cotes2020#2336](cotes2020#2336)) ([f744929](cotes2020@f744929))
    * recognize global theme mode ([cotes2020#2357](cotes2020#2357)) ([7708adb](cotes2020@7708adb))
    * **search:** avoid missing spaces between paragraphs in search results ([cotes2020#2199](cotes2020#2199)) ([0eb7efa](cotes2020@0eb7efa))
    * **ui:** fix incomplete border color on hover for tags ([cotes2020#2359](cotes2020#2359)) ([c626447](cotes2020@c626447))

    ### Improvements

    * **seo:** improve accessibility and aligns with best practices ([cotes2020#2289](cotes2020#2289)) ([54d4d59](cotes2020@54d4d59))

commit d84b727
Merge: 5e41d87 519e4f1
Author: Cotes Chung <[email protected]>
Date:   Sun May 18 21:16:09 2025 +0800

    Merge branch 'master' into production

commit 519e4f1
Author: Cotes Chung <[email protected]>
Date:   Sun May 18 21:14:56 2025 +0800

    chore: upgrade dependencies to the latest version (cotes2020#2409)

commit d0f8f95
Author: Cotes Chung <[email protected]>
Date:   Sun May 11 22:19:18 2025 +0800

    fix: improve accuracy of moving `img` element classes (cotes2020#2399)

commit 401e2af
Author: Cotes Chung <[email protected]>
Date:   Mon May 5 11:55:48 2025 +0800

    fix: avoid `mathjax` loading failure on page refresh (cotes2020#2389)

commit ada38aa
Author: Cotes Chung <[email protected]>
Date:   Mon May 5 11:15:08 2025 +0800

    chore: avoid auto-formatting liquid and sass mixed code

commit 61ae6cc
Author: Cotes Chung <[email protected]>
Date:   Mon May 5 11:14:07 2025 +0800

    chore(dev-deps): add eslint config file

commit 9f38a2d
Author: Cotes Chung <[email protected]>
Date:   Sat May 3 16:18:52 2025 +0800

    refactor: move the path of `theme.js`

commit 23d953c
Author: Cotes Chung <[email protected]>
Date:   Sat May 3 16:14:50 2025 +0800

    chore(deps): remove plugin `jekyll-redirect-from`

    Discussed in cotes2020#2313

commit b48ea68
Author: iSpeakNerd <[email protected]>
Date:   Thu Apr 24 05:25:46 2025 -0700

    chore: update `linkedin` sharing url (cotes2020#2307)

commit c626447
Author: László Várady <[email protected]>
Date:   Thu Apr 24 14:23:43 2025 +0200

    fix(ui): fix incomplete border color on hover for tags (cotes2020#2359)

commit 7708adb
Author: Cotes Chung <[email protected]>
Date:   Wed Apr 16 18:08:43 2025 +0800

    fix: recognize global theme mode (cotes2020#2357)

commit 167c98c
Author: Delyn Choong <[email protected]>
Date:   Sun Apr 13 22:16:47 2025 +0800

    feat(i18n): add Catalan Spanish locale translation (cotes2020#2349)

commit f744929
Author: László Várady <[email protected]>
Date:   Mon Apr 7 13:36:32 2025 +0200

    fix: prevent the search bar from moving when focused (cotes2020#2336)

commit db40db6
Author: Alejandro <[email protected]>
Date:   Sat Apr 5 01:28:29 2025 +0200

    chore: add parameter in `search-results.html` (cotes2020#2330)

commit 571c90f
Author: nakamura <[email protected]>
Date:   Sat Mar 29 04:54:54 2025 +0900

    feat(i18n): add Japanese locale (cotes2020#2295)

commit 54d4d59
Author: Türkalp Burak KAYRANCIOĞLU <[email protected]>
Date:   Sat Mar 8 17:24:47 2025 +0300

    perf(seo): improve accessibility and aligns with best practices (cotes2020#2289)

commit e315864
Author: Corey Goldberg <[email protected]>
Date:   Tue Mar 4 16:06:37 2025 -0500

    docs: fix typo in `2019-08-08-write-a-new-post.md` (cotes2020#2281)

    Signed-off-by: Corey Goldberg <[email protected]>

commit 7d4d35c
Author: MasihGhaznavi <[email protected]>
Date:   Sun Feb 9 09:58:39 2025 +0330

    feat(i18n): add persian language (cotes2020#2238)

commit 231956d
Author: algorithmic-parallels <[email protected]>
Date:   Thu Feb 6 00:27:54 2025 -0500

    docs: using long form Jekyll subcommand (cotes2020#2231)

Signed-off-by: datta0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RlxChap2 RlxChap2 RlxChap2 left review comments

@cotes2020 cotes2020 cotes2020 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alazaroc @cotes2020 @RlxChap2