Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestNativeHistogramFuzz #6677

Merged

Conversation

SungJin1212
Copy link
Member

This PR fixes the flaky TestNativeHistogramFuzz test using the compareFloats when comparing float64 values.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • [NA] Documentation added
  • [NA] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@SungJin1212 SungJin1212 force-pushed the Fix-flaky-TestNativeHistogramFuzz branch from 7b61294 to 2921762 Compare March 28, 2025 11:54
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Thanks for the awesome work!

@yeya24 yeya24 merged commit a582154 into cortexproject:master Apr 3, 2025
17 checks passed
wilguo pushed a commit to wilguo/cortex that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants