Skip to content

Commit a582154

Browse files
authored
Fix flaky TestNativeHistogramFuzz (#6677)
Signed-off-by: SungJin1212 <[email protected]>
1 parent 3c6be6d commit a582154

File tree

1 file changed

+18
-1
lines changed

1 file changed

+18
-1
lines changed

integration/query_fuzz_test.go

+18-1
Original file line numberDiff line numberDiff line change
@@ -949,8 +949,25 @@ var comparer = cmp.Comparer(func(x, y model.Value) bool {
949949
const fraction = 1.e-10 // 0.00000001%
950950
return cmp.Equal(l, r, cmpopts.EquateNaNs(), cmpopts.EquateApprox(fraction, epsilon))
951951
}
952+
compareHistogramBucket := func(l, r *model.HistogramBucket) bool {
953+
return l == r || (l.Boundaries == r.Boundaries && compareFloats(float64(l.Lower), float64(r.Lower)) && compareFloats(float64(l.Upper), float64(r.Upper)) && compareFloats(float64(l.Count), float64(r.Count)))
954+
}
955+
956+
compareHistogramBuckets := func(l, r model.HistogramBuckets) bool {
957+
if len(l) != len(r) {
958+
return false
959+
}
960+
961+
for i := range l {
962+
if !compareHistogramBucket(l[i], r[i]) {
963+
return false
964+
}
965+
}
966+
return true
967+
}
968+
952969
compareHistograms := func(l, r *model.SampleHistogram) bool {
953-
return l.Equal(r)
970+
return l == r || (l.Count == r.Count && compareFloats(float64(l.Sum), float64(r.Sum)) && compareHistogramBuckets(l.Buckets, r.Buckets))
954971
}
955972

956973
// count_values returns a metrics with one label {"value": "1.012321"}

0 commit comments

Comments
 (0)