fix for query_rejection bug #6145
Conversation
Signed-off-by: Erlan Zholdubai uulu <[email protected]>
erlan-z
force-pushed
the
query-rejection-bug-fix
branch
from
032106f to
71da81f
Compare
Signed-off-by: Erlan Zholdubai uulu <[email protected]>
| @@ -14,7 +14,7 @@ import ( | |||
| "github.com/cortexproject/cortex/pkg/util/validation" | |||
| ) | |||
|
|
|||
| const QueryRejectErrorMessage = "This query has been rejected by the service operator." | |||
| const QueryRejectErrorMessage = "This query does not perform well and has been rejected by the service operator." | |||
There was a problem hiding this comment.
It is probably unnecessary for this one. But we do make the message a flag in Ingester in order to customize it. https://github.com/cortexproject/cortex/blob/master/pkg/ingester/ingester.go#L162
There was a problem hiding this comment.
I wonder if we want to include the first part does not perform well. If a regex accidentally matches a good query, does it confuse users?
There was a problem hiding this comment.
In that case, it gives good reason to user to reach out service operator asking why that query does not perform well. We want user to reach out to service team if query is rejected by accident so I think it's good idea to have this part of the error message in case of accidental match.
There was a problem hiding this comment.
OK. I think we can leave it for now.
What this PR does:
Fix for bug in query rejection
Which issue(s) this PR fixes:
Fixes #6143
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]