Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Rejection for Metadata Queries Bug #6143

Closed
erlan-z opened this issue Aug 7, 2024 · 0 comments · Fixed by #6145
Closed

Query Rejection for Metadata Queries Bug #6143

erlan-z opened this issue Aug 7, 2024 · 0 comments · Fixed by #6145

Comments

@erlan-z
Copy link
Contributor

erlan-z commented Aug 7, 2024

Describe the bug
When Query Rejection configured with only properties that is not applicable for the API, then it rejects all the metadata queries. For example, dashboard_uid and panel_id headers are not provided for Metadata queries, and if query rejection configured to only those two fields, then it will reject all the Metadata queries for that tenant.

To Reproduce
Steps to reproduce the behavior:
Configure Query rejection with below config

    query_rejection:
      enabled: true
      query_attributes:
        - dashboard_uid: "dash123"
          panel_id: "panel123"
  1. Start Cortex (SHA or version)
  2. Perform Operations(Query metadata API)

Expected behavior
It should only reject queries that is matching the query_attributes. It shouldn't be rejecting metadata queries because they don't match (no dashboard_uid or panel_id header for them)

Environment:

  • Any

Additional Context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant