Upload blocks no compaction marks to the global location and introduce a new cortex_bucket_blocks_marked_for_no_compaction_count metric
#4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanprot
force-pushed
the
non-compact-blocks-gauge
branch
from
e10b9bb to
cd9707c
Compare
alanprot
changed the title
cortex_bucket_blocks_marked_for_no_compaction_count metric
…ortex_bucket_blocks_marked_for_deletion_count
alanprot
force-pushed
the
non-compact-blocks-gauge
branch
from
3ef3251 to
5563e2b
Compare
alvinlin123
reviewed
May 12, 2022
| } | ||
| for mark, globalFilePath := range marks { | ||
| // Look up mark (if any). | ||
| reader, err := userBucket.Get(ctx, path.Join(blockID.String(), mark)) |
There was a problem hiding this comment.
mark can be now both, the deletion and no-compact mark.
alvinlin123
reviewed
May 12, 2022
alvinlin123
approved these changes
May 12, 2022
alvinlin123
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Follow up of #4707.
no-compactmarks to the global marks locationWhich issue(s) this PR fixes:
Fixes: #4727
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]