-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatcher groups limits #4254
Dispatcher groups limits #4254
Conversation
This PR builds on top of #4237, marking as draft until it is merged. |
4b93c22
to
908e04c
Compare
Rebased on top of master now, ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can't see anything wrong here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! LGTM (modulo a comment about config name which I think we can make a bit more consistent with the rest of the config).
Should we mark these new limits as experimental?
Thanks for review.
I've marked all recently added Alertmanager limits as experimental for now. |
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
… features. Signed-off-by: Peter Štibraný <[email protected]>
0dd19e5
to
4618a92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (modulo a fix to the CHANGELOG entry). Thanks!
Signed-off-by: Peter Štibraný <[email protected]>
What this PR does: This PR exposes new alertmanager limit: number of active dispatcher groups in Alertmanager.
This PR builds on top of #4237, and will be rebased once #4237 is merged.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]