-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Alertmanager to latest master (8b584eb2265e). #4237
Conversation
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Integration tests currently failing due to bug in JSON-marshalling of URL wrapper. PRs with the fix: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good assuming the upstream fixes are merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the changes in alertmanager and common: LGTM (modulo the URL marshalling issue you've found).
A nit, non blocking: while looking at the code I've noticed a TODO at integration/e2ecortex/client.go:211
. Can we fix it?
I don't see what struct to use here. Alertmanager v1 api uses inline struct to send the response:
|
I think it was added by @jtlisi: do you remember it? In any case, this is definitely not a blocker, so please merge this PR as soon as ready. |
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
…479cc2511e. Signed-off-by: Peter Štibraný <[email protected]>
Since this added features and deprecated others, it really needed a CHANGELOG comment. |
The new feature side was added to CHANGELOG in #4325. |
What this PR does: This PR updates alertmanager to latest master (prometheus/alertmanager@f686ff3).
Which issue(s) this PR fixes:
Fixes #4234
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]