Wait for alertmanagers to complete state sync before becoming ACTIVE. #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Applies to sharding operation only. When starting up, make sure that the initial state sync is completed for any users which were initially assigned to the instance. This will reduce the possibility that we lose state when [cleanly] scaling up or down, by inadvertently losing the replica which we need to obtain state from. This change allows the state sync to progress concurrently for all tenants. The alternative would be to block for the service in `New()`, which is a slightly simpler code change, but would mean that start-up is potentially much slower. Signed-off-by: Steve Simpson <[email protected]>
pracucci
approved these changes
May 10, 2021
Signed-off-by: Steve Simpson <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Note: Applies to sharding operation only.
When starting up, make sure that the initial state sync is completed for
any users which were initially assigned to the instance. This will reduce
the possibility that we lose state when [cleanly] scaling up or down, by
inadvertently losing the replica which we need to obtain state from.
This change allows the state sync to progress concurrently for all
tenants. The alternative would be to block for the service in
New(),which is a slightly simpler code change, but would mean that start-up
is potentially much slower.
Checklist
Tests updatedDocumentation addedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]