Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for alertmanager sharding and add experimental warning log. #4222

Merged
merged 1 commit into from
May 28, 2021

Conversation

stevesg
Copy link
Contributor

@stevesg stevesg commented May 25, 2021

What this PR does:

  • Add changelog for alertmanager sharding now the implementation is complete
  • Add experimental warning log for the feature

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@stevesg stevesg marked this pull request as ready for review May 25, 2021 13:19
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job working on this feature! 🎉

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a final question). Thanks!

…log.

Signed-off-by: Steve Simpson <[email protected]>

Review comments.

Signed-off-by: Steve Simpson <[email protected]>

Fix doing numbers bad.

Signed-off-by: Steve Simpson <[email protected]>
@pstibrany pstibrany merged commit 00cf889 into cortexproject:master May 28, 2021
ac1214 pushed a commit to ac1214/cortex that referenced this pull request Jun 4, 2021
…log. (cortexproject#4222)

Signed-off-by: Steve Simpson <[email protected]>

Review comments.

Signed-off-by: Steve Simpson <[email protected]>

Fix doing numbers bad.

Signed-off-by: Steve Simpson <[email protected]>
Signed-off-by: Albert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants