Querier can now notify about its shutdown without providing any authentication in the context. #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
changed the title
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
pstibrany
force-pushed
the
fix-issue-4064
branch
from
356ea8f to
09c412d
Compare
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
approved these changes
Apr 9, 2021
Signed-off-by: Marco Pracucci <[email protected]>
I've run into exactly the same problem when working on query-scheduler ;-) |
Signed-off-by: Peter Štibraný <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR allows querier to call
/frontend.Frontend/NotifyClientShutdownand/schedulerpb.SchedulerForQuerier/NotifyQuerierShutdownwithout authentication.Which issue(s) this PR fixes:
Fixes #4064
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]