Skip to content

Remove experimental tag on WAL #2560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
* [ENHANCEMENT] query-frontend now also logs the POST data of long queries. #2481
* [ENHANCEMENT] Experimental WAL: Ingester WAL records now have type header and the custom WAL records have been replaced by Prometheus TSDB's WAL records. Old records will not be supported from 1.3 onwards. Note: once this is deployed, you cannot downgrade without data loss. #2436
* [ENHANCEMENT] Redis Cache: Added `idle_timeout`, `wait_on_pool_exhaustion` and `max_conn_lifetime` options to redis cache configuration. #2550
* [ENHANCEMENT] WAL: the experimental tag has been removed on the WAL in ingesters.
* [BUGFIX] Ruler: Ensure temporary rule files with special characters are properly mapped and cleaned up. #2506
* [BUGFIX] Fixes #2411, Ensure requests are properly routed to the prometheus api embedded in the query if `-server.path-prefix` is set. #2372
* [BUGFIX] Experimental TSDB: fixed chunk data corruption when querying back series using the experimental blocks storage. #2400
Expand Down
2 changes: 1 addition & 1 deletion docs/architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ The **write-ahead log** (WAL) is used to write to a persistent local disk all in

Contrary to the sole replication and given the persistent local disk data is not lost, in the event of multiple ingesters failure each ingester will recover the in-memory series samples from WAL upon subsequent restart. The replication is still recommended in order to ensure no temporary failures on the read path in the event of a single ingester failure.

The WAL for the chunks storage is an experimental feature (disabled by default), while it's always enabled for the blocks storage.
The WAL for the chunks storage is disabled by default, while it's always enabled for the blocks storage.

#### Ingesters write de-amplification

Expand Down
1 change: 0 additions & 1 deletion docs/configuration/v1-guarantees.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ Cortex is an actively developed project and we want to encourage the introductio
Currently experimental features are:

- TSDB block storage.
- Ingester chunk WAL.
- Cassandra storage engine.
- Azure blob storage.
- Zone awareness based replication.
Expand Down
2 changes: 0 additions & 2 deletions docs/production/ingesters-with-wal.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ Currently the ingesters running in the chunks storage mode, store all their data

To use WAL, there are some changes that needs to be made in the deployment.

_The WAL is currently considered experimental._

## Changes to deployment

1. Since ingesters need to have the same persistent volume across restarts/rollout, all the ingesters should be run on [statefulset](https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/) with fixed volumes.
Expand Down
2 changes: 0 additions & 2 deletions pkg/ingester/wal.go
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,6 @@ func newWAL(cfg WALConfig, userStatesFunc func() map[string]*userState, register
return &noopWAL{}, nil
}

util.WarnExperimentalUse("Chunks WAL")

var walRegistry prometheus.Registerer
if registerer != nil {
walRegistry = prometheus.WrapRegistererWith(prometheus.Labels{"kind": "wal"}, registerer)
Expand Down