Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove experimental tag on WAL #2560

Merged
merged 2 commits into from
May 11, 2020
Merged

Remove experimental tag on WAL #2560

merged 2 commits into from
May 11, 2020

Conversation

codesome
Copy link
Contributor

@codesome codesome commented May 5, 2020

Signed-off-by: Ganesh Vernekar [email protected]

What this PR does:

We at Grafana are running WAL in production and it is stable enough to remove the experimental tag.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Ganesh Vernekar <[email protected]>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codesome ! There are few places in the doc where WAL is mentioned experimental:

  • architecture.md: The WAL for the chunks storage is an experimental feature
  • v1-guarantees.md: - Ingester chunk WAL.
  • ingesters-with-wal.md: The WAL is currently considered experimental

Signed-off-by: Ganesh Vernekar <[email protected]>
@codesome
Copy link
Contributor Author

Thanks @pracucci, I have fixed them.

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great job on WAL!

@pstibrany pstibrany merged commit b44dc01 into cortexproject:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants