Skip to content

fixing sklearn dep #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .conda/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ requirements:
run:
- pytorch>=1.10
- numpy
- scikit-learn<=1.0.2 # newer versions require py3.8
- scikit-learn
- scipy

test:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/run_test_suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ jobs:
- name: Install dependencies
run: |
pip install pytest nbval jupyter tqdm matplotlib torchvision scipy
pip install -r requirements.txt
python setup.py build develop
pip install "pyro-ppl<=1.8";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpleiss is there a reason we require pyro-ppl<=1.8? would be good to unpin that, esp. b/c 1.8 doesn't (fully) work with python 3.10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think we can unpin.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, we can do that in a separate PR I guess.

- name: Run example notebooks
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ channels:
dependencies:
- pytorch
- numpy
- scikit-learn<=1.0.2 # newer versions require py3.8
- scikit-learn
- scipy
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
torch>=1.10
numpy
scikit-learn<=1.0.2 # newer versions require py3.8
scikit-learn
scipy
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def find_version(*file_paths):
install_requires = []
except ImportError:
pass
install_requires += ["numpy", "scikit-learn<=1.0.2", "scipy"]
install_requires += ["numpy", "scikit-learn", "scipy"]


# Run the setup
Expand Down