fixing sklearn dep

[ngam]

Follows #2057 and fixes tests: https://github.com/ngam/gpytorch/runs/7271650629?check_suite_focus=true

Recommendation: expand testing matrix to include python versions:

    strategy:
      matrix:
        python-version: ["3.7", "3.8", "3.9", "3.10"]
    ...
    ...
      with:
        python-version: ${{ matrix.python-version }}

[gpleiss]

With this change in place, python setup.py build develop and python setup.py install now both fail on Python 3.7. I confirmed this on my machine.

I think this is okay, since installing gpytorch#master via pip (i.e. pip install --upgrade git+https://github.com/cornellius-gp/gpytorch.git) still works. This is what we recommend in the README.

@Balandat thoughts?

[adamjstewart]

python setup.py * is deprecated: https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html

Does pip install . work?

[ngam]

With this change in place, python setup.py build develop and python setup.py install now both fail on Python 3.7. I confirmed this on my machine.

Sure, but will it fail if you do python -m pip install -r requirement.txt && python setup.py build develop and python -m pip install -r requirement.txt && python setup.py install?

I really do not understand why python setup.py build develop ends up installing a weird scikit-learn... what does it actually trigger behind the scenes for the deps??

[ngam]

Let me try to think a little about this. This is really weird.

[ngam]

@adamjstewart added you as a collaborator in my fork, feel free to edit this PR as you see fit. Didn't mean for this PR to overtake yours, I was just demonstrating a possible fix...

[ngam]

Could you authorize ci to run? @gpleiss

[Balandat]

@Balandat thoughts?

Aren’t we planning to remove py37 support in the next release (moving to LinearOperator - yes I still owe a review on that one)? In that case everything should be fine.

[Balandat]

@gpleiss is there a reason we require pyro-ppl<=1.8? would be good to unpin that, esp. b/c 1.8 doesn't (fully) work with python 3.10

[gpleiss]

Yeah I think we can unpin.

[Balandat]

Cool, we can do that in a separate PR I guess.

[Balandat]

gtmtl