-
Notifications
You must be signed in to change notification settings - Fork 810
plugin version unknown (1.4.1 release) #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is going to create problems to other tools: https://github.com/GEANT/nomad_cni/blob/main/lib/facter/nomad_cni_version.rb#L10 I hope you could delete and reissue this version. |
Or just release 1.4.2 instead of re-publishing, maybe to address #1033 too |
+1 |
@s1061123 can you take a look? I know you worked on automated release building. |
In the mean time, I'll re-build the release with the version set properly. |
Rebuilt the release, PTAL |
@squeed I got that script misses build version (ldflags in release.sh script). Will fix that soon. |
This changes adds BuildVersion linker flag in release to fix CNI plugins output. Fixes containernetworking#1019. Signed-off-by: Tomofumi Hayashi <[email protected]>
Hi, The latest builds (1.4.1) of the CNI plugins are not printing the plugin versions when run.
I've tested both x86_64 and Arm64 packages. I suspect changes in the build process since 1.4.0 release missed setting
BuildVersion
.# /opt/cni/bin/dummy CNI dummy plugin version unknown CNI protocol versions supported: 0.1.0, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 1.0.0
The text was updated successfully, but these errors were encountered: