Skip to content

CNI base plugins version detection broken since CNI 1.4.0 (broken upstream) #20263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bfqrst opened this issue Apr 2, 2024 · 9 comments
Closed
Assignees
Labels
stage/waiting-on-upstream This issue is waiting on an upstream PR review theme/cni type/bug

Comments

@bfqrst
Copy link

bfqrst commented Apr 2, 2024

Nomad version

Nomad v1.7.6
BuildDate 2024-03-12T07:27:36Z
Revision 594fedb

Operating system and Environment details

Ubuntu Jammy

Issue

Clients detail page in the Nomad UI shows 1.0.0 across the board for CNI plugins.

Reproduction steps

Check the respective UI page in the GUI of a v1.7.6 client.

Expected Result

Something like this on a v1.7.5 client tab:

image

Actual Result

image

Job file (if appropriate)

Nomad Server logs (if appropriate)

Nomad Client logs (if appropriate)

@bfqrst bfqrst added the type/bug label Apr 2, 2024
@tgross
Copy link
Member

tgross commented Apr 2, 2024

Hi @bfqrst I happen to have been working on something related to this recently, so this caught my eye right away. I checked this myself and with an older version of CNI plugins the fingerprint works fine, even with Nomad 1.7.6. But on the latest version, it looks like they're missing their version strings.

Ex. with 1.1.1

$ /opt/cni/bin/portmap --version
CNI portmap plugin v1.1.1

But with 1.4.1:

$ /opt/cni/bin/portmap --version
CNI portmap plugin version unknown
CNI protocol versions supported: 0.1.0, 0.2.0, 0.3.0, 0.3.1, 0.4.0, 1.0.0

So I think this is an upstream bug in the plugin builds? Can you check that on your cluster as well?

@tgross
Copy link
Member

tgross commented Apr 2, 2024

Ah, yeah I see this is reported upstream: containernetworking/plugins#1019

@tgross
Copy link
Member

tgross commented Apr 2, 2024

Fortunately we won't have to revert #15473 because we only required 0.4.0 and these will detect as 1.0.0 because of the way the version gets fingerprinted.

@tgross tgross added stage/waiting-on-upstream This issue is waiting on an upstream PR review stage/waiting-reply labels Apr 2, 2024
@tgross tgross self-assigned this Apr 2, 2024
@bfqrst
Copy link
Author

bfqrst commented Apr 2, 2024

Ah, damn, could've checked myself upstream...

THX @tgross

@tgross tgross changed the title CNI version detection broken since v1.7.6 CNI version detection broken since CNI 1.4.1 (broken upstream) Apr 2, 2024
@tgross tgross changed the title CNI version detection broken since CNI 1.4.1 (broken upstream) CNI version detection broken since CNI 1.4.0 (broken upstream) Apr 2, 2024
@tgross
Copy link
Member

tgross commented Apr 2, 2024

Ok we'll leave this open until it's fixed upstream just so folks who come looking for it see it. Not much we can do from Nomad's side unfortunately, as the data just isn't in the --version output for us to get.

@bfqrst
Copy link
Author

bfqrst commented Apr 2, 2024

Understood, makes sense.

@tgross tgross changed the title CNI version detection broken since CNI 1.4.0 (broken upstream) CNI base plugins version detection broken since CNI 1.4.0 (broken upstream) Apr 5, 2024
@tgross
Copy link
Member

tgross commented May 17, 2024

Upstream has re-released 1.4.1 (without a new version, see containernetworking/plugins#1038).

@tgross tgross closed this as completed May 17, 2024
@bfqrst
Copy link
Author

bfqrst commented May 21, 2024

Confirming that v1.5.0 (the latest as of today) also shows fine in Nomad...

Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/waiting-on-upstream This issue is waiting on an upstream PR review theme/cni type/bug
Projects
Development

No branches or pull requests

2 participants