-
Notifications
You must be signed in to change notification settings - Fork 2k
CNI base plugins version detection broken since CNI 1.4.0 (broken upstream) #20263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @bfqrst I happen to have been working on something related to this recently, so this caught my eye right away. I checked this myself and with an older version of CNI plugins the fingerprint works fine, even with Nomad 1.7.6. But on the latest version, it looks like they're missing their version strings. Ex. with 1.1.1
But with 1.4.1:
So I think this is an upstream bug in the plugin builds? Can you check that on your cluster as well? |
Ah, yeah I see this is reported upstream: containernetworking/plugins#1019 |
Fortunately we won't have to revert #15473 because we only required 0.4.0 and these will detect as 1.0.0 because of the way the version gets fingerprinted. |
Ah, damn, could've checked myself upstream... THX @tgross |
Ok we'll leave this open until it's fixed upstream just so folks who come looking for it see it. Not much we can do from Nomad's side unfortunately, as the data just isn't in the |
Understood, makes sense. |
Upstream has re-released 1.4.1 (without a new version, see containernetworking/plugins#1038). |
Confirming that v1.5.0 (the latest as of today) also shows fine in Nomad... |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v1.7.6
BuildDate 2024-03-12T07:27:36Z
Revision 594fedb
Operating system and Environment details
Ubuntu Jammy
Issue
Clients detail page in the Nomad UI shows 1.0.0 across the board for CNI plugins.
Reproduction steps
Check the respective UI page in the GUI of a v1.7.6 client.
Expected Result
Something like this on a v1.7.5 client tab:
Actual Result
Job file (if appropriate)
Nomad Server logs (if appropriate)
Nomad Client logs (if appropriate)
The text was updated successfully, but these errors were encountered: