Skip to content

Improvements to language client error handling #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

noeldevelops
Copy link
Member

@noeldevelops noeldevelops commented May 16, 2025

Summary of Changes

  • Re-enables the language server in extension activation
  • Adds one more error handler to the language client setup to catch initialization errors
  • Removes the diagnostics processing, which does not have an effect on the lag with diagnostics we're seeing
  • Checks the server "is running" value instead of "needs start" when deciding whether to reinitialize

Any additional details or context that should be provided?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file?
    gulp clicktest

@noeldevelops noeldevelops marked this pull request as ready for review May 16, 2025 16:25
@noeldevelops noeldevelops requested a review from a team as a code owner May 16, 2025 16:25
@noeldevelops noeldevelops changed the base branch from v1.3.x to main May 16, 2025 19:28
@noeldevelops noeldevelops marked this pull request as draft May 16, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants