Skip to content

Disable language client on activate (for now) #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

Disable language client on activate (for now) #1815

merged 1 commit into from
May 15, 2025

Conversation

noeldevelops
Copy link
Member

Summary of Changes

  • Comments out the line that initializes language client code. We are finding too many flaky errors and don't want to release with this UX. It will be reenabled shortly when we find the cause!

Any additional details or context that should be provided?

Pull request checklist

Please check if your PR fulfills the following (if applicable):

Tests
  • Added new
  • Updated existing
  • Deleted existing
Other
  • All new disposables (event listeners, views, channels, etc.) collected as for eventual cleanup?
  • Does anything in this PR need to be mentioned in the user-facing CHANGELOG or README?
  • Have you validated this change locally by packaging and installing the extension .vsix file? 
    gulp clicktest

@noeldevelops noeldevelops marked this pull request as ready for review May 15, 2025 22:39
@noeldevelops noeldevelops requested a review from a team as a code owner May 15, 2025 22:39
@noeldevelops noeldevelops merged commit 7d7345a into v1.3.x May 15, 2025
10 checks passed
@noeldevelops noeldevelops deleted the ncothren/disable-lang-client branch May 15, 2025 22:46
airlock-confluentinc bot pushed a commit that referenced this pull request May 16, 2025
@noeldevelops
disable language client on activate (#1815)
434c3be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSeal MSeal MSeal approved these changes

@shouples shouples shouples approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noeldevelops @MSeal @shouples