Skip to content

docs: What to do when there is a custom license #11720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 18, 2022
Merged

docs: What to do when there is a custom license #11720

merged 5 commits into from
Jul 18, 2022

Conversation

prince-chrismc
Copy link
Contributor

Docs!

@prince-chrismc
docs: what to do when there is a custom license
d6aa681 
this came up in conan-io#11121 and I am trying to capture the information
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@prince-chrismc
Copy link
Contributor Author

I really dont like how many places this has gone.

Open to any suggestions 🙏

@prince-chrismc prince-chrismc mentioned this pull request Jul 15, 2022
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Updating docs!

@github-actions github-actions bot mentioned this pull request Jul 15, 2022
Open
@prince-chrismc prince-chrismc mentioned this pull request Jul 15, 2022
Merged
4 tasks
uilianries
uilianries approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good solution, IHMO. So far, we needed to read and get the license name from the file, which now always work, as they vary the name according the interpretation.

@conan-center-bot conan-center-bot merged commit dada12f into conan-io:master Jul 18, 2022
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 29, 2022
@prince-chrismc @AndreyMlashkin
(conan-io#11720) docs: What to do when there is a custom license
039d7ba 
* docs: what to do when there is a custom license

this came up in conan-io#11121 and I am trying to capture the information

* link hook rules to FAQ

* also put it in the faq

* relative link same as conan-io#10639

* Update reviewing.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prince-chrismc @conan-center-bot @SSE4 @uilianries