Skip to content

libglvnd 1.4.0 #11121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Aug 6, 2022
Merged

libglvnd 1.4.0 #11121

merged 19 commits into from
Aug 6, 2022

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented Jun 10, 2022 •
edited
Loading

Specify library name and version: libglvnd/1.4.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier
Copy link
Contributor Author

This is blocked until conan 1.48 is deployed on C3I, cf conan-io/conan#11065

Croydon
Croydon reviewed Jun 10, 2022
View reviewed changes
Croydon
Croydon reviewed Jun 10, 2022
View reviewed changes
Croydon
Croydon reviewed Jun 10, 2022
View reviewed changes
recipes/libglvnd/all/conanfile.py
required_conan_version = ">=1.45.0"

class LibGlvndConan(ConanFile):
name = "libglvnd"
Copy link
Contributor

@Croydon Croydon Jun 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note: My understanding is, that this might be the better replacement for all the places we currently use opengl/system, but this might break compatibility for older systems with older GPU drivers and in general GPU drivers that aren't supported by glvnd.

We probably would need the currently opengl/system package in the form of an optional mesa-opengl/system package or something, but it wouldn't necessarily be required, as any driver would be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, some of the distros install glvnd as system opengl too (https://ubuntu.pkgs.org/22.04/ubuntu-main-amd64/libgl-dev_1.4.0-1_amd64.deb.html), so mesa-opengl/system is probably not the good name either.

@ericLemanissier ericLemanissier mentioned this pull request Jun 11, 2022
Merged
4 tasks
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@ericLemanissier
Copy link
Contributor Author

This is ready for review @Croydon @SSE4 @uilianries

Croydon
Croydon previously approved these changes Jul 11, 2022
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
conan-center-bot pushed a commit that referenced this pull request Jul 18, 2022
@prince-chrismc
(#11720) docs: What to do when there is a custom license
dada12f 
* docs: what to do when there is a custom license

this came up in #11121 and I am trying to capture the information

* link hook rules to FAQ

* also put it in the faq

* relative link same as #10639

* Update reviewing.md
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
AndreyMlashkin pushed a commit to AndreyMlashkin/conan-center-index that referenced this pull request Jul 29, 2022
@prince-chrismc @AndreyMlashkin
(conan-io#11720) docs: What to do when there is a custom license
039d7ba 
* docs: what to do when there is a custom license

this came up in conan-io#11121 and I am trying to capture the information

* link hook rules to FAQ

* also put it in the faq

* relative link same as conan-io#10639

* Update reviewing.md
@conan-center-bot
Copy link
Collaborator

All green in build 26 (c6166c70cd6e37f413369687afc24a5c3e4b539c):

  • libglvnd/1.4.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit ad68e02 into conan-io:master Aug 6, 2022
@ericLemanissier ericLemanissier deleted the libglvnd branch August 6, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@Croydon Croydon Croydon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ericLemanissier @conan-center-bot @prince-chrismc @SSE4 @Croydon