-
Notifications
You must be signed in to change notification settings - Fork 1.5k
port: (2025 Ioniq5) HKG Angle Steering LFA2 #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
devtekve
wants to merge
14
commits into
commaai:master
Choose a base branch
from
sunnypilot:hkg-ioniq5-lfa2-upstream
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rol and interface definitions
Refactor torque reduction gain definitions, update rate limits, and improve override logic alignment with observed ADAS behavior.
…torque reduction gain calculation and update angle steering control flow.
…er_angle_limits` into class, streamline method calls, and clean up logic.
…whitespace, and maintain code consistency.
…y_hyundai_steer_angle_limits`, add torque reduction gain logic, and improve method parameter flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Depends on
This PR introduces the minimum required changes to safely support angle-based steering control on HKG vehicles, starting with the 2025 Hyundai Ioniq 5, which I personally own. This vehicle serves as the initial reference platform for the “official” port.
Although the current implementation works across all HKG angle steering vehicles we've tested so far, additional safety-related data needs to be gathered on a per-model and per-region basis. Merging support for this vehicle now enables faster iteration and testing for the remaining variants.
✅ What’s Included
❓ Remaining Unknowns
We do not yet fully understand how the
Torque Reduction Gain
setting behaves across different HKG vehicles. This parameter, used by the EPS controller, appears to differ by model and region (so far US vs. Rest of the World). While it does not affect core safety constraints, it may influence driver comfort and perceived steering responsiveness.We could implement additional checks to ensure the driver can always override the system, but this might be redundant: the EPS controller already disables assist when the driver applies more than approximately 10 Nm of torque, ensuring manual control takes precedence when needed, although requiring significant override force.
🔍 Observations on Torque Reduction Gain
This parameter has been observed to fluctuate during live drives with Lane Following Assist (LFA) enabled. It tends to settle to a steady value when driving on straight roads, but:
These differences suggest regional or model-specific EPS tuning. However, the impact on steering feel and override responsiveness still requires further study. There is currently no evidence that these values compromise safety enforcement, but we intend to gather more structured data as we expand support.
Testing
e1107f9d04dfb1e2/00000281--d21e3d98e5