-
Notifications
You must be signed in to change notification settings - Fork 1.5k
HKG: Add hands-on detection signal for LFA2 vehicles #2420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message looks to have a usable COUNTER and cyclically-repeating CHECKSUM, which I'd presume uses one of the existing HKG checksum algorithms. Can you add those fields? Will merge once that's done.
@jyoung8607 this does not have
Screen.Recording.2025-07-02.at.9.28.17.AM.movEdit: Doing a "quick & dirty" search on the dbcs for canfd I don't see an instance where CHECKSUM exists but COUNTER does not, so I wouldn't like to define it and it meaning something else (even though it kinda points to be checksum) |
From the very beginning of the route, with no motion and no hands-on/torque applied yet, the rest of the message beyond the counter and (assumed, unverified) checksum is invariant, so we can see the cyclic repetition on both. The counter is mod 0xF rather than mod 0x10 but I see that's done with some other HKG messages already. I'll go ahead and merge this message as-is, so you'll have it for informational purposes, but I'd suggest adding CHECKSUM and COUNTER support before shipping a car port that makes active use of this detection. |
Oh! Thank you for that insight, I was under the wrong assumption that the checksum was meant to be 2 bytes but clearly not. My comment for it not having counter was solely based on the fact that the 3rd byte was already identified properly, it never crossed my mind the 2nd byte would be having the counter! |
Add hands on detection signal for LFA2 vehicles
This signal is for LFA2 vehicles that uses steering grip sensor. https://www.hyundaimotorgroup.com/innovation/CONT0000000000005027

Validation
e1107f9d04dfb1e2
e1107f9d04dfb1e2/0000025f--8df0049cd4
Note
The signal name is not 100% confirmed officially. This is because while I found found the signal on an official DBC, the message address was not the same as what I found, and neither was the structure completely. However, the values themselves mapped to what I found, so my only guess is that the signal simply got updated since the dbc I found.
Note
needed by: #1676