-
Notifications
You must be signed in to change notification settings - Fork 22
feat(react-components): add hybrid cad mappings support - step 1 #5107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good, only minor comments. Good work 💯
react-components/src/architecture/concrete/pointsOfInterest/ads/createUpsertRequestFromPois.ts
Outdated
Show resolved
Hide resolved
4cfeec8
to
16b3344
Compare
16b3344
to
6e4fc23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments for the journey
react-components/src/components/CacheProvider/AnnotationModelUtils.ts
Outdated
Show resolved
Hide resolved
react-components/src/components/CacheProvider/AnnotationModelUtils.test.ts
Outdated
Show resolved
Hide resolved
…9-hybrid-cad-mappings-part1
…e along only changes made in further pr
3ea07ed
to
544f0d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5107 +/- ##
==========================================
- Coverage 56.36% 56.33% -0.03%
==========================================
Files 1124 1124
Lines 81641 81693 +52
Branches 5980 5983 +3
==========================================
+ Hits 46013 46023 +10
- Misses 35287 35329 +42
Partials 341 341
🚀 New features to boost your workflow:
|
Type of change
This is a stacked PR:
Jira ticket 📘
https://cognitedata.atlassian.net/browse/BND3D-4989
https://cognitedata.atlassian.net/browse/BND3D-5576
https://cognitedata.atlassian.net/browse/
Description 📝
How has this been tested? 🔍
Test instructions ℹ️
Checklist ☑️