Skip to content

feat(react-components): add hybrid cad mappings support - step 1 #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

danpriori
Copy link
Contributor

@danpriori danpriori commented Apr 21, 2025

Type of change

Feat

This is a stacked PR:

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4989
https://cognitedata.atlassian.net/browse/BND3D-5576

https://cognitedata.atlassian.net/browse/

Description 📝

  • Add base types, typeguards, keys and combined asset fetching supports

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am happy with this implementation.
  • I have performed a self-review of my own code.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have added documentation to new and changed elements; both public and internally shared ones
  • I have refactored the code for testability, readability and extendibility to the best of my ability.
  • I have listed the JIRA tasks covering remaining work or tech debt related to this PR in the description.

Copy link
Contributor

@anders-hopland anders-hopland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, only minor comments. Good work 💯

@danpriori danpriori changed the base branch from danpriori/BND3D-4989-hybrid-cad-mappings-part2 to master April 22, 2025 13:49
@danpriori danpriori changed the base branch from master to danpriori/BND3D-4989-hybrid-cad-mappings-part2 April 22, 2025 13:50
@danpriori danpriori changed the base branch from danpriori/BND3D-4989-hybrid-cad-mappings-part2 to master May 1, 2025 21:26
@danpriori danpriori changed the base branch from master to danpriori/BND3D-4989-hybrid-cad-mappings-part2 May 1, 2025 21:27
@danpriori danpriori changed the base branch from danpriori/BND3D-4989-hybrid-cad-mappings-part2 to master May 4, 2025 16:59
@danpriori danpriori force-pushed the danpriori/BND3D-4989-hybrid-cad-mappings-part1 branch from 4cfeec8 to 16b3344 Compare May 4, 2025 17:04
@danpriori danpriori force-pushed the danpriori/BND3D-4989-hybrid-cad-mappings-part1 branch from 16b3344 to 6e4fc23 Compare May 4, 2025 17:28
@danpriori danpriori changed the title feat(react-components): add hybrid cad mappings support (part 1) feat(react-components): add hybrid cad mappings support - step 1 May 5, 2025
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments for the journey

@danpriori danpriori force-pushed the danpriori/BND3D-4989-hybrid-cad-mappings-part1 branch from 3ea07ed to 544f0d1 Compare May 9, 2025 08:20
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 50.79365% with 31 lines in your changes missing coverage. Please review.

Project coverage is 56.33%. Comparing base (64f74c1) to head (62521ae).

Files with missing lines Patch % Lines
...t-components/src/components/CacheProvider/utils.ts 7.14% 13 Missing ⚠️
...rc/components/CacheProvider/idAndKeyTranslation.ts 12.50% 7 Missing ⚠️
...omponents/CacheProvider/Image360AnnotationCache.ts 28.57% 5 Missing ⚠️
...eact-components/src/utilities/instanceIds/toKey.ts 20.00% 4 Missing ⚠️
...t-components/src/components/CacheProvider/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5107      +/-   ##
==========================================
- Coverage   56.36%   56.33%   -0.03%     
==========================================
  Files        1124     1124              
  Lines       81641    81693      +52     
  Branches     5980     5983       +3     
==========================================
+ Hits        46013    46023      +10     
- Misses      35287    35329      +42     
  Partials      341      341              
Files with missing lines Coverage Δ
...c/components/CacheProvider/AnnotationModelUtils.ts 97.67% <100.00%> (+2.80%) ⬆️
...t-components/src/components/CacheProvider/types.ts 0.00% <ø> (ø)
...components/src/utilities/instanceIds/typeGuards.ts 100.00% <100.00%> (ø)
...eact-components/src/utilities/instanceIds/types.ts 100.00% <ø> (ø)
...t-components/src/components/CacheProvider/index.ts 0.00% <0.00%> (ø)
...eact-components/src/utilities/instanceIds/toKey.ts 25.00% <20.00%> (-6.25%) ⬇️
...omponents/CacheProvider/Image360AnnotationCache.ts 17.43% <28.57%> (+0.92%) ⬆️
...rc/components/CacheProvider/idAndKeyTranslation.ts 29.41% <12.50%> (-5.21%) ⬇️
...t-components/src/components/CacheProvider/utils.ts 25.00% <7.14%> (-5.00%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants