Skip to content

feat(react-components): add hybrid cad mappings support - step 5 #5102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: danpriori/BND3D-4989-hybrid-cad-mappings-part7
Choose a base branch
from

Conversation

danpriori
Copy link
Contributor

@danpriori danpriori commented Apr 21, 2025

Type of change

Feat

This is a stacked PR:

Jira ticket 📘

https://cognitedata.atlassian.net/browse/BND3D-4989
https://cognitedata.atlassian.net/browse/BND3D-5576

https://cognitedata.atlassian.net/browse/

Description 📝

  • Add reveal 3d resource types for stylings, style translation and custom viewer for unit testing.
  • Add hybrid cad asset mappings hook to be used by useCalculateInstanceStyling hook

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am happy with this implementation.
  • I have performed a self-review of my own code.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have added documentation to new and changed elements; both public and internally shared ones
  • I have refactored the code for testability, readability and extendibility to the best of my ability.
  • I have listed the JIRA tasks covering remaining work or tech debt related to this PR in the description.

Copy link
Contributor

@anders-hopland anders-hopland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor comments

@danpriori danpriori force-pushed the danpriori/BND3D-4989-hybrid-cad-mappings-part6 branch from 7a1945c to 3702769 Compare May 5, 2025 13:43
@danpriori danpriori force-pushed the danpriori/BND3D-4989-hybrid-cad-mappings-part6 branch from 3702769 to 1ec37ae Compare May 5, 2025 13:51
@danpriori danpriori changed the title feat(react-components): add hybrid cad mappings support (part 6) feat(react-components): add hybrid cad mappings support - step 5 May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants