Skip to content

minor adjustments #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.idea
.vscode
.DS_Store
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This action assumes you use [poetry](https://python-poetry.org/) as your package
**This action is also supported on private GitHub actions runners**. If you do not use a custom runner, you may use the builtin functionality `GITHUB_TOKEN` with write permissions as the `ACCESS_TOKEN` as seen in the first example. See [https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow)


> :warning: We recommend you to use this workflow with the test pypi registry e.g. `REGISTRY: "https://test.pypi.org/simple/"` until you can confirm your workflow works as expected.
> :warning: We recommend you to use this workflow with the test PyPI registry e.g. `REGISTRY: "https://test.pypi.org/simple/"` until you can confirm your workflow works as expected.

## Process

Expand Down Expand Up @@ -36,7 +36,7 @@ Each example requires you to:
1. Create a workflow file e.g. `.github/workflows/publish.yml`
2. Create a new release and tag e.g. `1.0.0` and the action will be triggered and publishes your package

### publish.yaml to publish to public pypi
### publish.yaml to publish to public PyPI

- Requires GitHub secrets:
- `PYPI_PASSWORD` with a valid token
Expand Down Expand Up @@ -65,7 +65,7 @@ jobs:
PYPI_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
```

### publish.yaml to publish to the test pypi
### publish.yaml to publish to the test PyPI

- Requires GitHub secrets:
- `PYPI_PASSWORD` with a valid token
Expand All @@ -92,10 +92,10 @@ jobs:
REGISTRY: "https://test.pypi.org/legacy/"
```

### publish.yaml to publish to a private pypi
### publish.yaml to publish to a private PyPI

- Requires GitHub secrets:
- `PYPI_USER` username for the pypi registry
- `PYPI_USER` username for the PyPI registry
- `PYPI_PASSWORD` with the password for the `PYPI_USER` user
- `ACCESS_TOKEN` access token with write access to the GitHub repository

Expand All @@ -110,7 +110,7 @@ jobs:
publish-service-client-package:
runs-on: ubuntu-latest
steps:
- name: Publish PyPi package
- name: Publish PyPI package
uses: code-specialist/pypi-poetry-publish@v1
with:
PACKAGE_DIRECTORY: "./example-package/"
Expand Down
6 changes: 3 additions & 3 deletions action.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: 'PyPi Poetry Publish'
name: 'PyPI Poetry Publish'
description: 'Opinionated GitHub action to fully automate publishing packages to any PyPI registry - using Poetry and GitHub releases'
branding:
icon: 'package'
Expand All @@ -16,7 +16,7 @@ inputs:
required: false
default: '3.10'
PYPI_PASSWORD:
description: 'Password for the user to publish to PyPi. May also be a Token - requires the `PYPI_USERNAME` to be `__token__`'
description: 'Password for the user to publish to PyPI. May also be a Token - requires the `PYPI_USERNAME` to be `__token__`'
required: true
PYPI_USERNAME:
description: 'The username for the registry. Defaults to __token__'
Expand Down Expand Up @@ -60,7 +60,7 @@ runs:
- name: Add and Commit Version
run: |
git add ${{ inputs.PACKAGE_DIRECTORY }}__init__.py ./pyproject.toml
git config --global user.name "PyPi Poetry Publish Bot"
git config --global user.name "PyPI Poetry Publish Bot"
git config --global user.email "[email protected]"
git commit -m "Change version to ${{ github.event.release.tag_name }}" --allow-empty
git push origin HEAD:${{ inputs.BRANCH }}
Expand Down