Skip to content

minor adjustments #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2022
Merged

minor adjustments #1

merged 1 commit into from
Nov 19, 2022

Conversation

JonasScholl
Copy link
Contributor

Looks great, thx 👍 I have just some really small suggestions, so that the "PyPI" name is consistently spelled correctly.

The only additional thing I could imagine to be nice is to include something like this for the required project setup:

my-project/
    my-project/
        __init__.py
    pyproject.toml

and also an explicit example of the __init__.py, e.g.

__version__='1.0.0'

However, I couldn't think of a nice way to add this to the readme so far, that's why I didn't include it in this pr

@yannicschroeer yannicschroeer merged commit f37965d into main Nov 19, 2022
@yannicschroeer yannicschroeer deleted the minor-adjustments branch November 19, 2022 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants