CH57x bringup and blinky, debugprintfdemo #561

biemster · 2025-03-13T13:48:37Z

This PR is of course still untested, but a preparation to hit the ground running when the boards are released.
It's a copy of the current work on CH59x in #534, with the correct registers and stuff for CH570/2 of course.

cnlohr · 2025-03-14T00:01:47Z

To clarify, I want to make sure this is run through its paces before we merge.

biemster · 2025-03-14T00:11:38Z

definitely, also everyone is invited to add to this pr since it will be a while before i receive a 570, customs here is difficult (or create a new one based on this, or not based on it at all, for now this is just a starting off point)

sw · 2025-04-02T08:10:19Z

WCH is now selling CH570 evaluation boards (promo code XJI0YRGF5ZXY). The silkscreen says CH572, though, so I wonder if this is really the limited CH570 without bluetooth support.

biemster · 2025-04-02T08:13:29Z

WCH is now selling CH570 evaluation boards. The silkscreen says CH572, though, so I wonder if this is really the limited CH570 without bluetooth support.

I did not notice the silkscreen.. We'll find out when the boards arrive, anyway either is fine to test this PR, BLE or RF is not touched yet.

biemster · 2025-04-04T12:18:25Z

I've added ch573 too, since I have one to test this on. The bringup and blinky works, but minichlink has trouble with the debugprintf. In https://github.com/biemster/ch573_minimal the debug print works exactly the same as in biemster/ch592_minimal, so I highly suspect this to be an issue with minichlink and not the mcu code.

EDIT: the new -k option for minichlink makes terminal work on ch573, so this PR is fully tested on the 3!

biemster · 2025-04-06T12:24:30Z

This needs rebasing, which would ideally be done after #582 goes in.

sw · 2025-04-10T17:54:57Z

Should this work with minichlink? This is what I get with a CH570D:

../../ch32fun//../minichlink/minichlink -w blink.bin flash -b
Found WCH Link
WCH Programmer is LinkE version 2.14
Already Connected
Full Chip Type Reply: [4] 81-55-01-01-00-00-00-00-00
Unknown chip fallback
No detected chip.
Setup success
Interface Setup
Writing image
Fault on op (DMABSTRACTS = 08000302) (100) (Execption executing Abstract Command) DMSTATUS: 004c0382
Chip Type: 1ff
Unknown chip type.  Report as bug with picture of chip.
Vendored: 1ffff704
marchid : dc68d863
HARTINFO: 00212340

Image written.

A note on the blink example: It uses PA8 for the LED, but that is also /RST and better left alone. PA9 would be a good choice IMO, because that's right next to LED0 on the pin headers of the evaluation board.

biemster · 2025-04-10T17:58:37Z

Should this work with minichlink? This is what I get with a CH570D:

No minichlink support will have to be addressed in a different PR. All the ch5xx chips have issues with minichlink, you could try the same approach temporarily as in #574 to get terminal working, but flashing will not work for sure.

Did you try blink and did it work?? That would be amazing!

sw · 2025-04-10T18:32:06Z

Did you try blink and did it work?? That would be amazing!

No, I haven't been able to flash it. From your earlier comments I thought you did manage that?

I've also tried the openocd fork distributed by WCH, without success:

$ ./openocd -f wch-riscv.cfg 
Open On-Chip Debugger 0.11.0+dev-02415-gfad123a16-dirty (2024-11-20-13:09)
Licensed under GNU GPL v2
For bug reports, read
	http://openocd.org/doc/doxygen/bugs.html
Info : only one transport option; autoselect 'sdi'
Warn : Transport "sdi" was already selected
Ready for Remote Connections
Info : Listening on port 6666 for tcl connections
Info : Listening on port 4444 for telnet connections
Info : WCH-LinkE  mode:RV version 2.14 
Error:  WCH-Link failed to connect with riscvchip
Error:  1.Make sure the two-line debug interface has been opened. If not, set board to boot mode then use ISP tool to open it
Error:  2.Please check your physical link connection

biemster · 2025-04-10T18:42:07Z

Did you try blink and did it work?? That would be amazing!

No, I haven't been able to flash it. From your earlier comments I thought you did manage that?

No sorry, I did not even receive my board yet! You could try https://github.com/ch32-rs/wchisp but I don't think they have a flashloader for it yet. So try just wchisp info first.

biemster · 2025-04-30T17:21:47Z

Some huge rebase / merge went on here, I need to test this from the start again

biemster · 2025-04-30T17:23:15Z

I think I destroyed this PR, there are 63 changed files now. Maybe better to start afresh

ch32fun/ch32fun.c

ch32fun/ch32fun.h

ch32fun/ch32fun.ld

examples_ch59x/systick_irq/systick_irq.c

examples_x00x/adc_polled/adc_polled.c

minichlink/pgm-b003fun.c

biemster · 2025-04-30T20:21:03Z

@cnlohr please stop reviewing this :D something went wrong rebasing the whole thing, git and I are not the best of friends
edit: sorry I did not notice earlier that you were commenting on it

biemster · 2025-04-30T20:38:31Z

I don't understand how it pulled in all these other commits, the branch on my forks looks alright?

biemster · 2025-04-30T20:53:41Z

I think I revived the branch, it can be merged cleanly again. I'll just fix the examples (tomorrow)

cnlohr · 2025-04-30T21:24:04Z

Marking all resolved for the time being.

biemster · 2025-05-01T13:11:40Z

This is now ready for review and merge, I managed to recover from the rebase difficulties. It's fully tested and working on ch573 and ch570.

cnlohr · 2025-05-01T18:22:26Z

examples_ch57x/debugprintfdemo/debugprintfdemo.c

@@ -17,17 +23,17 @@ int main()
 {
 	SystemInit();



We should still do a funGpioInitAll(), and in ch32fun.h, make it #define funGpioInitAll() I would like general consistency. Could also add a comment, "doesn't actually do anything on the ch5xx chips.

Ok I'll add that. I hope I remember during the ch5xx consolidation, the ch58x and ch59x don't have this either.

cnlohr · 2025-05-01T18:22:59Z

ch32fun/ch57xhw.h

@@ -225,9 +225,15 @@ typedef enum
 } SYS_CLKTypeDef;

 // For debug writing to the debug interface.
+#if MCU_PACKAGE == 3


Add a comment explaining what package 3 is.

ch57(3), I thought it worked like that on the other mcu's as well, but thinking of it now that's not really possible ofc 😄

Just add a comment, for people who are casually reading the source code.

cnlohr · 2025-05-01T18:23:50Z

examples_ch57x/blink/funconfig.h

@@ -3,7 +3,7 @@

 #define FUNCONF_USE_HSI           0 // CH57x does not have HSI
 #define FUNCONF_USE_HSE           1
-#define CLK_SOURCE_CH57X          CLK_SOURCE_PLL_60MHz // default so not really needed. CH570/2 can go up to 100MHz
+#define CLK_SOURCE_CH5XX          CLK_SOURCE_PLL_60MHz // default so not really needed. CH570/2 can go up to 100MHz


Wonderful way to define it!

yeah this worked out quite nice!

biemster · 2025-05-01T20:09:01Z

Done! I don't know if you usually squash commits while merging, but considering the weird state this PR was in yesterday I'd suggest to definitely do that this time.

cnlohr · 2025-05-01T22:26:37Z

Oh you didn't need to update the comment everywhere but I'll accept it!

Squash and merge it is!

biemster changed the title ~~CH570/2 bringup and blinky, debugprintfdemo~~ CH57x bringup and blinky, debugprintfdemo Apr 4, 2025

sw mentioned this pull request Apr 22, 2025

Error on the new CH570D-R0-1v0 board ch32-rs/wchisp#86

Open

biemster mentioned this pull request Apr 30, 2025

CH5xx consolidation #594

Open

6 tasks

biemster added 2 commits April 30, 2025 18:57

initial commit, copy of ch59x work in cnlohr#534

507eee5

add CH573 as well

839e8d1

cnlohr reviewed Apr 30, 2025

View reviewed changes

biemster force-pushed the ch57x-bringup branch from 1fc93f6 to 839e8d1 Compare April 30, 2025 20:50

make ch570 prime target (also recover rebase mess)

09b92b7

biemster marked this pull request as ready for review May 1, 2025 13:11

cnlohr reviewed May 1, 2025

View reviewed changes

PR comments: explain MCU_PACKAGE, funGpioInitAll()

e0e77dc

cnlohr merged commit 03a6924 into cnlohr:master May 1, 2025
98 checks passed

CH57x bringup and blinky, debugprintfdemo #561

CH57x bringup and blinky, debugprintfdemo #561

Conversation

biemster commented Mar 13, 2025

Uh oh!

cnlohr commented Mar 14, 2025

Uh oh!

biemster commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sw commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

biemster commented Apr 2, 2025

Uh oh!

biemster commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

biemster commented Apr 6, 2025

Uh oh!

sw commented Apr 10, 2025

Uh oh!

biemster commented Apr 10, 2025

Uh oh!

sw commented Apr 10, 2025

Uh oh!

biemster commented Apr 10, 2025

Uh oh!

biemster commented Apr 30, 2025

Uh oh!

biemster commented Apr 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

biemster commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

biemster commented Apr 30, 2025

Uh oh!

biemster commented Apr 30, 2025

Uh oh!

cnlohr commented Apr 30, 2025

Uh oh!

biemster commented May 1, 2025

Uh oh!

cnlohr May 1, 2025

Choose a reason for hiding this comment

Uh oh!

biemster May 1, 2025

Choose a reason for hiding this comment

Uh oh!

cnlohr May 1, 2025

Choose a reason for hiding this comment

Uh oh!

biemster May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnlohr May 1, 2025

Choose a reason for hiding this comment

Uh oh!

cnlohr May 1, 2025

Choose a reason for hiding this comment

Uh oh!

biemster May 1, 2025

Choose a reason for hiding this comment

Uh oh!

biemster commented May 1, 2025

Uh oh!

cnlohr commented May 1, 2025

Uh oh!

Uh oh!

Uh oh!

biemster commented Mar 14, 2025 •

edited

Loading

sw commented Apr 2, 2025 •

edited

Loading

biemster commented Apr 4, 2025 •

edited

Loading

biemster commented Apr 30, 2025 •

edited

Loading

biemster May 1, 2025 •

edited

Loading