Skip to content

v3.1.0 #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 76 commits into from
Sep 14, 2018
Merged

v3.1.0 #156

merged 76 commits into from
Sep 14, 2018

Conversation

WaldoFR
Copy link

@WaldoFR WaldoFR commented Sep 13, 2018

Fixes

Changes proposed :

brigittehuynh and others added 30 commits June 20, 2018 19:35
(required for all issues regarding function location)
global variable handling with regards to the function
class to FunctionWithVariables in order to do so. Cleaned up unused
variables.
strings and comments are handled correctly
with a specific FunctionInvariant class. The test files are updated
accordingly.
into account. Test files updated accordingly
An error was corrected on the plugin.xml file on the SH.ERR.String rule.
A localization error was corrected in SH.INST.GetOpts.

The following rules did not need updating:
COM.DATA.Invariant
SH.DESIGN.Bash
SH.INST.Interpreter
SH.INST.Keywords
SH.INST.Variables

The following rules could not be updated with FNAME without errors
appearing in their automatic tests:
COM.FLOW.Recursion
COM.INST.CodeComment
COM.INST.Line
COM.PRES.Indent
SH.MET.PipeLine
SH.FLOW.CheckCodeReturn
They were either partially modified (COM.FLOW.Recursion,
SH.FLOW.CheckCodeReturn), or left as they were.
brigittehuynh and others added 20 commits September 12, 2018 08:48
statements with several options separated by a |.
Test file updated accordingly.
Fix #152 correct regex to verify ${#} test also
accordingly.
The modification led to rethinking the rule mechanism: the violations
are now checked on the fly rather than at the end of the file.
(overlooked in previous treatment of the issue)
Modifications were made by adding a "Parsing error" rule and to raise it
on JFlexException throwing instead of making the analysis stop.
@WaldoFR WaldoFR self-assigned this Sep 13, 2018
@WaldoFR WaldoFR merged commit c2cf78a into master Sep 14, 2018
@WaldoFR WaldoFR deleted the v3.1.0-dev branch September 20, 2018 07:50
begarco pushed a commit to begarco/i-CodeCNES that referenced this pull request Jan 25, 2020
begarco pushed a commit that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants