Skip to content

Localization #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brigittehuynh opened this issue Sep 11, 2018 · 1 comment
Closed

Localization #150

brigittehuynh opened this issue Sep 11, 2018 · 1 comment
Assignees
@brigittehuynh
Labels
bug shell

Comments

@brigittehuynh
Copy link
Collaborator

Expected behavior

All rules should have correctly localized violations. Followup of issue #49 to continue adding localizations

Actual behavior

Some rules still have incomplete violation localization.

Steps to reproduce behavior

In a test file, add a violation in a function, followed by a violation in main code: both localizations should be correct.

Correction plan

Add as many localizations as possible in version 3.1.0, with a focus -when it makes sense- on the rules for which correct localization might be more important.

Detection version

3.1.0-alpha4
@brigittehuynh brigittehuynh self-assigned this Sep 11, 2018
brigittehuynh added a commit that referenced this issue Sep 13, 2018
@brigittehuynh
#150 Localization of the SH.SYNC.Signals rule
874e58f
brigittehuynh added a commit that referenced this issue Sep 13, 2018
@brigittehuynh
#150 Localization of the SH.MET.PipeLine rule. Test files updated
29591fc 
accordingly.
The modification led to rethinking the rule mechanism: the violations
are now checked on the fly rather than at the end of the file.
brigittehuynh added a commit that referenced this issue Sep 13, 2018
@brigittehuynh
#150 Localized the COM.FLOW.FilePath rule. Test file updated accordingly
a858b8e
brigittehuynh added a commit that referenced this issue Sep 13, 2018
@brigittehuynh
#150 Localization of the COM.FLOW.FileExistence rule. Test file updated
6b553e2 
accordingly
brigittehuynh added a commit that referenced this issue Sep 13, 2018
@brigittehuynh
#150 Localization of the SH.IO.Redirect rule. Updated the test file
e911442 
accordingly
@brigittehuynh
Copy link
Collaborator Author

The following rules have been localized:

  • COM.FLOW.FilePath
  • SH.SYNC.Signals
  • SH.MET.PipeLine
  • COM.FLOW.FileExistence
  • SH.IO.Redirect

@brigittehuynh brigittehuynh mentioned this issue Sep 13, 2018
Merged
@WaldoFR WaldoFR mentioned this issue Sep 13, 2018
Merged
@WaldoFR WaldoFR closed this as completed Sep 14, 2018
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#150 Localization of the SH.SYNC.Signals rule
ac75829
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#150 Localization of the SH.MET.PipeLine rule. Test files u…
091b473 
…pdated

accordingly.
The modification led to rethinking the rule mechanism: the violations
are now checked on the fly rather than at the end of the file.
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#150 Localized the COM.FLOW.FilePath rule. Test file update…
0e76ebe 
…d accordingly
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#150 Localization of the COM.FLOW.FileExistence rule. Test …
035f0ff 
…file updated

accordingly
begarco pushed a commit to begarco/i-CodeCNES that referenced this issue Jan 25, 2020
@brigittehuynh
cnescatlab#150 Localization of the SH.IO.Redirect rule. Updated the t…
d28939f 
…est file

accordingly
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#150 Localization of the SH.SYNC.Signals rule
5d8be75
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#150 Localization of the SH.MET.PipeLine rule. Test files updated
7a5f9dd 
accordingly.
The modification led to rethinking the rule mechanism: the violations
are now checked on the fly rather than at the end of the file.
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#150 Localized the COM.FLOW.FilePath rule. Test file updated accordingly
0955339
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#150 Localization of the COM.FLOW.FileExistence rule. Test file updated
63b2009 
accordingly
begarco pushed a commit that referenced this issue Feb 2, 2020
@brigittehuynh
#150 Localization of the SH.IO.Redirect rule. Updated the test file
5906c59 
accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brigittehuynh brigittehuynh

Labels
bug shell
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WaldoFR @brigittehuynh