refactor(aws_lb): replace lookups with null checks for optional fields #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced usage of lookup() with direct null checks using ternary operators for optional fields in various AWS load balancer resources. This improves code readability, consistency, and aligns with Terraform best practices. There are no changes to functional behavior, ensuring backward compatibility.
|
|
Simplified null handling by replacing conditional checks with coalesce function for various target group and health check attributes. This improves readability and aligns with best practices for Terraform expressions. No functional changes are introduced with this update.
jnonino
approved these changes
Apr 3, 2025
|
Thank you @jnonino!! :) Could you release version |
|
Yes, but this was raised after the previous release: #67? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced usage of lookup() with direct null checks using ternary operators for optional fields in various AWS load balancer resources. This improves code readability, consistency, and aligns with Terraform best practices. There are no changes to functional behavior, ensuring backward compatibility.