Skip to content

Version 1.0.35 fails for redirect rules #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcschneider79 opened this issue Apr 2, 2025 · 3 comments · Fixed by #68
Closed

Version 1.0.35 fails for redirect rules #67

jcschneider79 opened this issue Apr 2, 2025 · 3 comments · Fixed by #68
Labels
bug Something isn't working

Comments

@jcschneider79
Copy link

jcschneider79 commented Apr 2, 2025

after upgrading to 1.0.35, our terraform plans fail with:

│ Error: Invalid value for input variable

│ 43: http_ports = {
│ 44: "force-to-https" : {
│ 45: type = "redirect"
│ 46: listener_port = 80
│ 47: port = 443
│ 48: protocol = "HTTPS"
│ 49: status_code = "HTTP_301"
│ 50: }
│ 51: }

│ element "force-to-https": attribute "target_group_port" is required.

Operation failed: failed running terraform plan (exit 1)

However, the documentation states:
"For redirect type, include listener port, host, path, port, protocol, query and status_code."
no mention of target_group_port and it does not make sense why you would require a target_group_port for a redirect rule

@jnonino
Copy link
Member

jnonino commented Apr 3, 2025

Hi @nickreynke, is this related to your recent changes?

@nickreynke
Copy link
Contributor

My bad! With my contributions I have overlooked that target_group_port may be optional if type is not forward. Fixed this in #68 @jnonino :)

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in CN Services - Terraform Modules Apr 3, 2025
@jnonino
Copy link
Member

jnonino commented Apr 3, 2025

Thanks @nickreynke fo the fix! And thanks @jcschneider79 for reporting the problem!

The fix is released in version 1.0.36!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants