yet more dpi shenanigans #8734
Merged
yet more dpi shenanigans #8734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
UI
cm13-github
added a commit
that referenced
this pull request
Mar 11, 2025
cm13-github
added a commit
that referenced
this pull request
Mar 11, 2025
cm13-github
added a commit
that referenced
this pull request
Mar 11, 2025
Drulikar
approved these changes
Mar 11, 2025
github-project-automation
bot
moved this from Awaiting Review
to Partially Approved / Mergeable
in Review Backlog
3 tasks
cm13-github
added a commit
that referenced
this pull request
Mar 11, 2025
Drulikar
approved these changes
Mar 11, 2025
This was referenced Mar 11, 2025
Closed
cm13-github
added a commit
that referenced
this pull request
Mar 12, 2025
cm13-github
added a commit
that referenced
this pull request
Mar 12, 2025
This was referenced Mar 13, 2025
cm13-github
added a commit
that referenced
this pull request
Mar 13, 2025
|
For fireteam scaling issue: |
cm13-github
added a commit
that referenced
this pull request
Mar 13, 2025
cm13-github
added a commit
that referenced
this pull request
Mar 13, 2025
github-project-automation
bot
moved this from Partially Approved / Mergeable
to Merged
in Review Backlog
ihatethisengine
pushed a commit
to ihatethisengine/cmss13
that referenced
this pull request
Mar 14, 2025
# About the pull request <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> follow up to cmss13-devs#8723, just respects the tgui scaling (now window scaling) pref globally, with windows either becoming bigger or zooming out this now applies to most simple html browsers, tgui say and some other miscellany # Explain why it's good for the game looks less silly :) # Testing Photographs and Procedure 4k monitor with 200% scaling: on "smaller zoom" mode:  on "larger windows" mode:  # Changelog :cl: qol: people with window scaling that is greater or less than 100% will now have windows scale, appropriate to the "window scaling" option in settings /:cl: --------- Co-authored-by: harryob <[email protected]> Co-authored-by: Drulikar <[email protected]>
ihatethisengine
pushed a commit
to ihatethisengine/cmss13
that referenced
this pull request
Mar 14, 2025
|
It's fixed!!! Thank you!!!!!!!!! |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 15, 2025
# About the pull request This PR is a follow up to #8734 that changed the type of a browser user from mob to client but there were a few lingering situations where it was not getting converted (VVing bit fields and I guess viewing tickets). Past that just cleanup generally in this file... # Explain why it's good for the game Working browsers that open? # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>  </details> # Changelog :cl: Drathek fix: Fixed browsers sometimes not handling a mob passed instead of a client (VV bitfields & tickets atleast) /:cl:
DarkLordCabbage
pushed a commit
to DarkLordCabbage/cmss13-Fork
that referenced
this pull request
Mar 22, 2025
# About the pull request This PR is a follow up to cmss13-devs#8734 that changed the type of a browser user from mob to client but there were a few lingering situations where it was not getting converted (VVing bit fields and I guess viewing tickets). Past that just cleanup generally in this file... # Explain why it's good for the game Working browsers that open? # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>  </details> # Changelog :cl: Drathek fix: Fixed browsers sometimes not handling a mob passed instead of a client (VV bitfields & tickets atleast) /:cl:
1 task
github-merge-queue bot
pushed a commit
to Aurorastation/Aurora.3
that referenced
this pull request
May 14, 2025
Got tired of the issues here when working on something else. Ported several PRs from /tg/station to fix DPI scaling issues. This was not a problem before 516, however 516 now respects Window's DPI setting, causing misalignment in several of our UI elements. This PR implements these ~~four~~ ~~five~~ six PRs: tgstation/tgstation#65686 tgstation/tgstation#89994 tgstation/tgstation#90416 tgstation/tgstation#90418 tgstation/tgstation#90796 cmss13-devs/cmss13#8734 ~~Does not include fixes with TGUI-Say. /tg/station refactored TGUI-Say after their port to React before they fixed DPI scaling, and this would be pain to deconstruct to port over to Inferno. Since porting to React is "inevitable", I considered it not worth my time to fix this.~~ Thanks to the assistance of harry, TGUI-Say fixes now included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
follow up to #8723, just respects the tgui scaling (now window scaling) pref globally, with windows either becoming bigger or zooming out
this now applies to most simple html browsers, tgui say and some other miscellany
Explain why it's good for the game
looks less silly :)
Testing Photographs and Procedure
4k monitor with 200% scaling:
on "smaller zoom" mode:
on "larger windows" mode:
Changelog
🆑
qol: people with window scaling that is greater or less than 100% will now have windows scale, appropriate to the "window scaling" option in settings
/:cl: