516: use iframe indexeddb for all storage, only use byondstorage as a fallback if github pages is down #8646
Conversation
cmss13-ci
bot
added
Github
hry-gh
changed the title
cmss13-ci
bot
added
Code Improvement
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
github-project-automation
bot
moved this from Awaiting Review
to Changes Requested
in Review Backlog
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
this is a bit of cmss13-devs/cmss13#8646 cmss13-devs/cmss13#8875 cmss13-devs/cmss13#8606 cmss13-devs/cmss13#8607 cmss13-devs/cmss13#8359 cmss13-devs/cmss13#7860 ( and thus ParadiseSS13/Paradise#25105 ParadiseSS13/Paradise#25205 ParadiseSS13/Paradise#25363 ParadiseSS13/Paradise#26423 and ParadiseSS13/Paradise#26433 ) tgstation/tgstation#89766 in order to work properly - using the efficient storage method, instead of the byond json method - github pages needs to be enabled and built from the gh-pages branch. because yeah --------- Co-authored-by: harryob <[email protected]>
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Drulikar
added
Stale Exempt
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
About the pull request
this works by uploading the iframe page to github pages, which we use as our iframe in game to be able to access a persistent indexeddb in 516
in production, we don't actually use this - we use the webroot cdn instead, so if github pages does down, only people developing locally (or forks without a cdn) will be impacted
if github pages does go down, we instead just fall back to using byondstorage. but as this is not present in the browser options otherwise, we don't load it at all unless required
follow up from #8359, complemented by #8607
Explain why it's good for the game
i hate byondstorage and its laggy (potentially)
Changelog
🆑
code: browser preference storage has changed (again)
/:cl: