removes chatsaving chug on 516 #8359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
UI
cm13-github
added a commit
that referenced
this pull request
Feb 5, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 5, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 5, 2025
Closed
cm13-github
added a commit
that referenced
this pull request
Feb 5, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 5, 2025
cmss13-ci
bot
added
Fix
cm13-github
added a commit
that referenced
this pull request
Feb 5, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 5, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 6, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 6, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 6, 2025
Closed
cm13-github
added a commit
that referenced
this pull request
Feb 6, 2025
This was referenced Feb 7, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 7, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 7, 2025
This was referenced Feb 7, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 7, 2025
cm13-github
added a commit
that referenced
this pull request
Feb 7, 2025
This was referenced Feb 8, 2025
Git-Nivrak
approved these changes
Feb 8, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 8, 2025
tl;dr we don't use byondstorage for chat history as this is insaaanely slow and leads to 5s lag spikes if you have any amount of chat history of note, this only works on a server with the webroot cdn enabled, because we need something that isn't the dreamseeker webserver for our indexeddb's origin :cl: fix: 516 does not get laggier as the round goes on anymore /:cl: --------- Co-authored-by: harryob <[email protected]>
github-merge-queue bot
pushed a commit
to Aurorastation/Aurora.3
that referenced
this pull request
Mar 26, 2025
this is a bit of cmss13-devs/cmss13#8646 cmss13-devs/cmss13#8875 cmss13-devs/cmss13#8606 cmss13-devs/cmss13#8607 cmss13-devs/cmss13#8359 cmss13-devs/cmss13#7860 ( and thus ParadiseSS13/Paradise#25105 ParadiseSS13/Paradise#25205 ParadiseSS13/Paradise#25363 ParadiseSS13/Paradise#26423 and ParadiseSS13/Paradise#26433 ) tgstation/tgstation#89766 in order to work properly - using the efficient storage method, instead of the byond json method - github pages needs to be enabled and built from the gh-pages branch. because yeah --------- Co-authored-by: harryob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it loads an invisible iframe from the webroot cdn/some other specified path (like one hosted on gh pages). once that’s loaded, the iframe listens for “message” events, and the tgui window uses postMessage to send the get/set/whatevers over to the iframe
there’s no network activity happening after the iframe is loaded, we just need to escape from the localhost:bunch of numbers origin so we have a persistent indexeddb
of note, this only works on a server with the webroot cdn enabled, because we need something that isn't the dreamseeker webserver for our indexeddb's origin (though #8646 means it works locally, too, by hosting it on github pages)
tl;dr we don't use byondstorage for chat history as this is insaaanely slow and leads to 5s lag spikes if you have any amount of chat history
🆑
fix: 516 does not get laggier as the round goes on anymore
/:cl: