Skip to content

fix: Make sure coalescelist does not throw error #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020
Merged

fix: Make sure coalescelist does not throw error #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
128 changes: 85 additions & 43 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,43 @@
<!-- This file was automatically generated by the `build-harness`. Make all changes to `README.yaml` and run `make readme` to rebuild this file. -->
<!--














** DO NOT EDIT THIS FILE
**
** This file was automatically generated by the `build-harness`.
** 1) Make all changes to `README.yaml`
** 2) Run `make init` (you only need to do this once)
** 3) Run`make readme` to rebuild this file.
**
** (We maintain HUNDREDS of open source projects. This is how we maintain our sanity.)
**















-->
[![README Header][readme_header_img]][readme_header_link]

[![Cloud Posse][logo]](https://cpco.io/homepage)
Expand Down Expand Up @@ -142,42 +181,47 @@ Check out these related projects.

## Help

**Got a question?**
**Got a question?** We got answers.

File a GitHub [issue](https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms/issues), send us an [email][email] or join our [Slack Community][slack].

[![README Commercial Support][readme_commercial_support_img]][readme_commercial_support_link]

## Commercial Support

Work directly with our team of DevOps experts via email, slack, and video conferencing.

We provide [*commercial support*][commercial_support] for all of our [Open Source][github] projects. As a *Dedicated Support* customer, you have access to our team of subject matter experts at a fraction of the cost of a full-time engineer.
## DevOps Accelerator for Startups

[![E-Mail](https://img.shields.io/badge/[email protected])][email]

- **Questions.** We'll use a Shared Slack channel between your team and ours.
- **Troubleshooting.** We'll help you triage why things aren't working.
- **Code Reviews.** We'll review your Pull Requests and provide constructive feedback.
- **Bug Fixes.** We'll rapidly work to fix any bugs in our projects.
- **Build New Terraform Modules.** We'll [develop original modules][module_development] to provision infrastructure.
- **Cloud Architecture.** We'll assist with your cloud strategy and design.
- **Implementation.** We'll provide hands-on support to implement our reference architectures.
We are a [**DevOps Accelerator**][commercial_support]. We'll help you build your cloud infrastructure from the ground up so you can own it. Then we'll show you how to operate it and stick around for as long as you need us.

[![Learn More](https://img.shields.io/badge/learn%20more-success.svg?style=for-the-badge)][commercial_support]

Work directly with our team of DevOps experts via email, slack, and video conferencing.

## Terraform Module Development

Are you interested in custom Terraform module development? Submit your inquiry using [our form][module_development] today and we'll get back to you ASAP.
We deliver 10x the value for a fraction of the cost of a full-time engineer. Our track record is not even funny. If you want things done right and you need it done FAST, then we're your best bet.

- **Reference Architecture.** You'll get everything you need from the ground up built using 100% infrastructure as code.
- **Release Engineering.** You'll have end-to-end CI/CD with unlimited staging environments.
- **Site Reliability Engineering.** You'll have total visibility into your apps and microservices.
- **Security Baseline.** You'll have built-in governance with accountability and audit logs for all changes.
- **GitOps.** You'll be able to operate your infrastructure via Pull Requests.
- **Training.** You'll receive hands-on training so your team can operate what we build.
- **Questions.** You'll have a direct line of communication between our teams via a Shared Slack channel.
- **Troubleshooting.** You'll get help to triage when things aren't working.
- **Code Reviews.** You'll receive constructive feedback on Pull Requests.
- **Bug Fixes.** We'll rapidly work with you to fix any bugs in our projects.

## Slack Community

Join our [Open Source Community][slack] on Slack. It's **FREE** for everyone! Our "SweetOps" community is where you get to talk with others who share a similar vision for how to rollout and manage infrastructure. This is the best place to talk shop, ask questions, solicit feedback, and work together as a community to build totally *sweet* infrastructure.

## Newsletter

Signup for [our newsletter][newsletter] that covers everything on our technology radar. Receive updates on what we're up to on GitHub as well as awesome new projects we discover.
Sign up for [our newsletter][newsletter] that covers everything on our technology radar. Receive updates on what we're up to on GitHub as well as awesome new projects we discover.

## Office Hours

[Join us every Wednesday via Zoom][office_hours] for our weekly "Lunch & Learn" sessions. It's **FREE** for everyone!

[![zoom](https://img.cloudposse.com/fit-in/200x200/https://cloudposse.com/wp-content/uploads/2019/08/Powered-by-Zoom.png")][office_hours]

## Contributing

Expand All @@ -202,7 +246,7 @@ In general, PRs are welcome. We follow the typical "fork-and-pull" Git workflow.

## Copyright

Copyright © 2017-2019 [Cloud Posse, LLC](https://cpco.io/copyright)
Copyright © 2017-2020 [Cloud Posse, LLC](https://cpco.io/copyright)



Expand Down Expand Up @@ -269,33 +313,31 @@ Check out [our other projects][github], [follow us on twitter][twitter], [apply
[aknysh_homepage]: https://github.com/aknysh
[aknysh_avatar]: https://img.cloudposse.com/150x150/https://github.com/aknysh.png



[![README Footer][readme_footer_img]][readme_footer_link]
[![Beacon][beacon]][website]

[logo]: https://cloudposse.com/logo-300x69.svg
[docs]: https://cpco.io/docs
[website]: https://cpco.io/homepage
[github]: https://cpco.io/github
[jobs]: https://cpco.io/jobs
[hire]: https://cpco.io/hire
[slack]: https://cpco.io/slack
[linkedin]: https://cpco.io/linkedin
[twitter]: https://cpco.io/twitter
[testimonial]: https://cpco.io/leave-testimonial
[newsletter]: https://cpco.io/newsletter
[email]: https://cpco.io/email
[commercial_support]: https://cpco.io/commercial-support
[we_love_open_source]: https://cpco.io/we-love-open-source
[module_development]: https://cpco.io/module-development
[terraform_modules]: https://cpco.io/terraform-modules
[readme_header_img]: https://cloudposse.com/readme/header/img?repo=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
[readme_header_link]: https://cloudposse.com/readme/header/link?repo=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
[readme_footer_img]: https://cloudposse.com/readme/footer/img?repo=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
[readme_footer_link]: https://cloudposse.com/readme/footer/link?repo=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
[readme_commercial_support_img]: https://cloudposse.com/readme/commercial-support/img?repo=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
[readme_commercial_support_link]: https://cloudposse.com/readme/commercial-support/link?repo=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
[docs]: https://cpco.io/docs?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=docs
[website]: https://cpco.io/homepage?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=website
[github]: https://cpco.io/github?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=github
[jobs]: https://cpco.io/jobs?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=jobs
[hire]: https://cpco.io/hire?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=hire
[slack]: https://cpco.io/slack?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=slack
[linkedin]: https://cpco.io/linkedin?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=linkedin
[twitter]: https://cpco.io/twitter?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=twitter
[testimonial]: https://cpco.io/leave-testimonial?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=testimonial
[office_hours]: https://cloudposse.com/office-hours?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=office_hours
[newsletter]: https://cpco.io/newsletter?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=newsletter
[email]: https://cpco.io/email?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=email
[commercial_support]: https://cpco.io/commercial-support?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=commercial_support
[we_love_open_source]: https://cpco.io/we-love-open-source?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=we_love_open_source
[terraform_modules]: https://cpco.io/terraform-modules?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=terraform_modules
[readme_header_img]: https://cloudposse.com/readme/header/img
[readme_header_link]: https://cloudposse.com/readme/header/link?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=readme_header_link
[readme_footer_img]: https://cloudposse.com/readme/footer/img
[readme_footer_link]: https://cloudposse.com/readme/footer/link?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=readme_footer_link
[readme_commercial_support_img]: https://cloudposse.com/readme/commercial-support/img
[readme_commercial_support_link]: https://cloudposse.com/readme/commercial-support/link?utm_source=github&utm_medium=readme&utm_campaign=cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms&utm_content=readme_commercial_support_link
[share_twitter]: https://twitter.com/intent/tweet/?text=terraform-aws-alb-target-group-cloudwatch-sns-alarms&url=https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
[share_linkedin]: https://www.linkedin.com/shareArticle?mini=true&title=terraform-aws-alb-target-group-cloudwatch-sns-alarms&url=https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
[share_reddit]: https://reddit.com/submit/?url=https://github.com/cloudposse/terraform-aws-alb-target-group-cloudwatch-sns-alarms
Expand Down
11 changes: 8 additions & 3 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ module "target_response_time_alarm_label" {

locals {
# default to using notify_arns unless a more specific action is specified.
alarm_actions = coalescelist(var.alarm_actions, var.notify_arns)
ok_actions = coalescelist(var.ok_actions, var.notify_arns)
insufficient_data_actions = coalescelist(var.insufficient_data_actions, var.notify_arns)
alarm_actions = compact(coalescelist(var.alarm_actions, var.notify_arns))
ok_actions = compact(coalescelist(var.ok_actions, var.notify_arns))
insufficient_data_actions = compact(coalescelist(var.insufficient_data_actions, var.notify_arns))

thresholds = {
target_3xx_count = max(var.target_3xx_count_threshold, 0)
Expand Down Expand Up @@ -90,6 +90,7 @@ resource "aws_cloudwatch_metric_alarm" "httpcode_target_3xx_count" {
ok_actions = local.ok_actions
insufficient_data_actions = local.insufficient_data_actions
dimensions = local.target_group_dimensions_map
tags = module.httpcode_target_3xx_alarm_label.tags
}

resource "aws_cloudwatch_metric_alarm" "httpcode_target_4xx_count" {
Expand All @@ -108,6 +109,7 @@ resource "aws_cloudwatch_metric_alarm" "httpcode_target_4xx_count" {
ok_actions = local.ok_actions
insufficient_data_actions = local.insufficient_data_actions
dimensions = local.target_group_dimensions_map
tags = module.httpcode_target_4xx_alarm_label.tags
}

resource "aws_cloudwatch_metric_alarm" "httpcode_target_5xx_count" {
Expand All @@ -126,6 +128,7 @@ resource "aws_cloudwatch_metric_alarm" "httpcode_target_5xx_count" {
ok_actions = local.ok_actions
insufficient_data_actions = local.insufficient_data_actions
dimensions = local.target_group_dimensions_map
tags = module.httpcode_target_5xx_alarm_label.tags
}

resource "aws_cloudwatch_metric_alarm" "httpcode_elb_5xx_count" {
Expand All @@ -144,6 +147,7 @@ resource "aws_cloudwatch_metric_alarm" "httpcode_elb_5xx_count" {
ok_actions = local.ok_actions
insufficient_data_actions = local.insufficient_data_actions
dimensions = local.load_balancer_dimensions_map
tags = module.httpcode_elb_5xx_alarm_label.tags
}

resource "aws_cloudwatch_metric_alarm" "target_response_time_average" {
Expand All @@ -162,4 +166,5 @@ resource "aws_cloudwatch_metric_alarm" "target_response_time_average" {
ok_actions = local.ok_actions
insufficient_data_actions = local.insufficient_data_actions
dimensions = local.target_group_dimensions_map
tags = module.target_response_time_alarm_label.tags
}
8 changes: 4 additions & 4 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,25 +42,25 @@ variable "enabled" {
variable "notify_arns" {
type = list(string)
description = "A list of ARNs (i.e. SNS Topic ARN) to execute when this alarm transitions into ANY state from any other state. May be overridden by the value of a more specific {alarm,ok,insufficient_data}_actions variable. "
default = []
default = [""]
}

variable "alarm_actions" {
type = list(string)
description = "A list of ARNs (i.e. SNS Topic ARN) to execute when this alarm transitions into an ALARM state from any other state. If set, this list takes precedence over notify_arns"
default = []
default = [""]
}

variable "ok_actions" {
type = list(string)
description = "A list of ARNs (i.e. SNS Topic ARN) to execute when this alarm transitions into an OK state from any other state. If set, this list takes precedence over notify_arns"
default = []
default = [""]
}

variable "insufficient_data_actions" {
type = list(string)
description = "A list of ARNs (i.e. SNS Topic ARN) to execute when this alarm transitions into an INSUFFICIENT_DATA state from any other state. If set, this list takes precedence over notify_arns"
default = []
default = [""]
}

variable "alb_arn_suffix" {
Expand Down