Skip to content

fix: Make sure coalescelist does not throw error #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

k911
Copy link
Contributor

@k911 k911 commented Dec 11, 2019

  • Also, add tags to alarms

Fixes #17

@k911
Copy link
Contributor Author

k911 commented Jan 13, 2020

@aknysh Could you please take a look?

@nicgordon
Copy link

Pretty keen for this one to be merged so we can stop using a forked version of https://github.com/cloudposse/terraform-aws-ecs-web-app. Does anyone have any capacity to release this? 🙏

@k911 k911 requested review from aknysh and osterman February 10, 2020 12:00
@maximmi
Copy link
Contributor

maximmi commented Feb 14, 2020

/codefresh run test

@k911 k911 force-pushed the fix/coalescelist-tf-012 branch from d69a9fc to 9e78a50 Compare February 16, 2020 22:07
@k911
Copy link
Contributor Author

k911 commented Feb 16, 2020

@maximmi I've updated readme

@maximmi
Copy link
Contributor

maximmi commented Feb 18, 2020

/codefresh run test

@k911
Copy link
Contributor Author

k911 commented Feb 20, 2020

@maximmi Anything more to be done?

Copy link
Contributor

@maximmi maximmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @k911 , we are good to go for release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coalescelist does not allow all lists to be empty
3 participants