Skip to content

dleq: Moves dleq to new top-level zero-knowledge package. #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2022
Merged

dleq: Moves dleq to new top-level zero-knowledge package. #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion oprf/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import (
"crypto/rand"

"github.com/cloudflare/circl/group"
"github.com/cloudflare/circl/group/dleq"
"github.com/cloudflare/circl/zk/dleq"
)

type client struct{ params }
Expand Down
2 changes: 1 addition & 1 deletion oprf/oprf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ import (
"math"

"github.com/cloudflare/circl/group"
"github.com/cloudflare/circl/group/dleq"
"github.com/cloudflare/circl/zk/dleq"
)

const (
Expand Down
2 changes: 1 addition & 1 deletion oprf/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"crypto/subtle"

"github.com/cloudflare/circl/group"
"github.com/cloudflare/circl/group/dleq"
"github.com/cloudflare/circl/zk/dleq"
)

type server struct {
Expand Down
2 changes: 1 addition & 1 deletion oprf/vectors_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ import (
"testing"

"github.com/cloudflare/circl/group"
"github.com/cloudflare/circl/group/dleq"
"github.com/cloudflare/circl/internal/test"
"github.com/cloudflare/circl/zk/dleq"
)

type vector struct {
Expand Down
23 changes: 15 additions & 8 deletions group/dleq/dleq.go → zk/dleq/dleq.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
// Package dleq provides zero-knowledge proofs of Discrete-Logarithm Equivalence (DLEQ).
//
// This implementation is compatible with the one used for VOPRFs [1].
// It supports batching proofs to amortize the cost of the proof generation and
// verification.
//
// References:
//
// [1] draft-irtf-cfrg-voprf: https://datatracker.ietf.org/doc/draft-irtf-cfrg-voprf
package dleq

import (
Expand All @@ -23,7 +31,6 @@ type Params struct {
}

type Proof struct {
g group.Group
c, s group.Scalar
}

Expand Down Expand Up @@ -84,7 +91,7 @@ func (p Prover) ProveBatchWithRandomness(
ss.Mul(cc, k)
ss.Sub(rnd, ss)

return &Proof{p.G, cc, ss}, nil
return &Proof{cc, ss}, nil
}

func (p Params) computeComposites(
Expand Down Expand Up @@ -223,7 +230,8 @@ func (v Verifier) VerifyBatch(a, ka group.Element, bi, kbi []group.Element, p *P
}

func (p *Proof) MarshalBinary() ([]byte, error) {
scalarSize := int(p.g.Params().ScalarLength)
g := p.c.Group()
scalarSize := int(g.Params().ScalarLength)
output := make([]byte, 0, 2*scalarSize)

serC, err := p.c.MarshalBinary()
Expand All @@ -242,19 +250,18 @@ func (p *Proof) MarshalBinary() ([]byte, error) {
}

func (p *Proof) UnmarshalBinary(g group.Group, data []byte) error {
p.g = g
scalarSize := int(p.g.Params().ScalarLength)
scalarSize := int(g.Params().ScalarLength)
if len(data) < 2*scalarSize {
return io.ErrShortBuffer
}

c := p.g.NewScalar()
c := g.NewScalar()
err := c.UnmarshalBinary(data[:scalarSize])
if err != nil {
return err
}

s := p.g.NewScalar()
s := g.NewScalar()
err = s.UnmarshalBinary(data[scalarSize : 2*scalarSize])
if err != nil {
return err
Expand All @@ -272,6 +279,6 @@ func mustWrite(h io.Writer, bytes []byte) {
panic(err)
}
if len(bytes) != bytesLen {
panic("failed to write on hash")
panic("dleq: failed to write on hash")
}
}
2 changes: 1 addition & 1 deletion group/dleq/dleq_test.go → zk/dleq/dleq_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import (
"testing"

"github.com/cloudflare/circl/group"
"github.com/cloudflare/circl/group/dleq"
"github.com/cloudflare/circl/internal/test"
"github.com/cloudflare/circl/zk/dleq"
)

func TestDLEQ(t *testing.T) {
Expand Down