Skip to content

dleq: Moves dleq to new top-level zero-knowledge package. #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

dleq: Moves dleq to new top-level zero-knowledge package. #372

merged 1 commit into from
Aug 31, 2022

Conversation

armfazh
Copy link
Contributor

@armfazh armfazh commented Aug 29, 2022 •
edited
Loading

Moves dleq to new top-level zero-knowledge package

@armfazh armfazh added the cosmetic readability an cleanliness of code label Aug 29, 2022
@armfazh armfazh requested review from bwesterb and cjpatton August 29, 2022 20:40
@armfazh armfazh self-assigned this Aug 29, 2022
cjpatton
cjpatton reviewed Aug 30, 2022
View reviewed changes
Copy link
Contributor

@cjpatton cjpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good (no functional changes, AFAICT). What's the motivation for renaming the package?

@armfazh
Copy link
Contributor Author

armfazh commented Aug 30, 2022

Change looks good (no functional changes, AFAICT). What's the motivation for renaming the package?

We plan to add another zk proof to this folder. See #370

@armfazh armfazh merged commit 4cf0150 into cloudflare:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpatton cjpatton cjpatton approved these changes

@bwesterb bwesterb Awaiting requested review from bwesterb

Assignees

@armfazh armfazh

Labels
cosmetic readability an cleanliness of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armfazh @cjpatton