t/71 Fixed: Wrong class names and invalid voice label in BoxedEditorUIView.

[oleq]

Closes #71.

[Reinmar]

Why "ck" instead of "cke"? We've been always using the latter.

[oleq]

It's shorter. And it's already used across the code-base. That's all.

[Reinmar]

"c" is even shorter but even less meaningful :P. We always had "cke" so switching to "ck" without clear reasons may be confusing. But it's up to you – I only wanted to stress that this must be consistent now, so e.g. data-cke-sth must become data-ck-sth, getCKEStuff, getCKStuff.

Therefore, if you want to propose CK you should actually ping all of us.

[Reinmar]

E.g., this would need to be changed as well https://github.com/ckeditor/ckeditor5-engine/blob/b30844d167441862e2ebc915e7d690ca41982df6/src/view/filler.js#L39-L47

[oleq]

We're already inconsistent in that matter

https://github.com/ckeditor/ckeditor5-utils/blob/master/src/dom/emittermixin.js#L283
vs.
https://github.com/ckeditor/ckeditor5-engine/blob/master/src/view/filler.js#L39

ATM. All the styles use ck- prefix and this issue is to make it consistent (+bonus totally broken voice label). If we want to change it all, then it's another issue, that's for sure.

[Reinmar]

And this: https://github.com/ckeditor/ckeditor5-utils/blob/06266b9c704b47ee972063d8d7cd5daf066be685/src/dom/emittermixin.js#L145

[Reinmar]

ATM. All the styles use ck- prefix and this issue is to make it consistent (+bonus totally broken voice label). If we want to change it all, then it's another issue, that's for sure.

I saw that they are inconsistent. But they can be inconsistent in both ways. So there's a question about standard and the standard was always different.

[oleq]

TBH, I don't think it matters. Especially at this point.

The purpose of this issue is making things consistent. If we go the other way, we end up with a multi–PR refactoring across the project which would consume time we cannot spare ATM.

[Reinmar]

You ended up with two PRs anyway.

If you don't want to work on this now, then please create a ticket and tag it for 1.0.0.

[oleq]

Moved the discussion to https://github.com/ckeditor/ckeditor5-ui/issues/112.