Skip to content

Rename cke- prefix to ck- in the codebase #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oleq opened this issue Nov 22, 2016 · 2 comments · Fixed by ckeditor/ckeditor5-ui#366
Closed

Rename cke- prefix to ck- in the codebase #5275

oleq opened this issue Nov 22, 2016 · 2 comments · Fixed by ckeditor/ckeditor5-ui#366
Assignees
@oleq
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 14

Comments

@oleq
Copy link
Member

oleq commented Nov 22, 2016

A follow-up of ckeditor/ckeditor5-ui-default#122.
@Reinmar
Copy link
Member

Reinmar commented Oct 10, 2017

@oleq, I'm leaving it up to you whether we should have ck- or cke-.

@oleq oleq changed the title Rename ck- prefix to cke- in the codebase Rename cke- prefix to ck- in the codebase Feb 1, 2018
@oleq
Copy link
Member Author

oleq commented Feb 1, 2018

I decided to go with ck- and I've been updating names (e.g. https://github.com/ckeditor/ckeditor5-image/pull/172/files) for some time now. Still, there are a couple of places left to fix.

@oleq oleq self-assigned this Feb 6, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-ui Feb 6, 2018
@Reinmar
Merge pull request #366 from ckeditor/t/112
7973f83 
Other: CSS classes should be prefixed with `ck-` instead of `cke-`. Closes #112.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

t/112: CSS classes should be prefixed with ck- instead of cke- ckeditor/ckeditor5-ui
3 participants
@Reinmar @oleq @mlewand