fix: Re-instantiation issue on parent update #659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated node for a
ref
in react life cycle seems to have an issue withreact-aptor
orplyr
which need more time for investigation, I used class selector instead to get the latest version of a video element node byplyr
package itself.It is backward compatible but is a hotfix bug which the user must know, Is there a need for doc update or new version announcement?
result of log statement for first render (
<App>0</App>
)and second render (<App>1</App>
) called ininstantiate
functionFixes: #654