Skip to content

How about keep state? #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gamestap99 opened this issue Oct 11, 2021 · 6 comments · Fixed by #659
Closed

How about keep state? #654

gamestap99 opened this issue Oct 11, 2021 · 6 comments · Fixed by #659
Assignees
Labels
bug Something isn't working

Comments

@gamestap99
Copy link

i am using video in a tab. when chaning tab i lost video state. How about fix it?

@gamestap99
Copy link
Author

Update issue when i changing a tab then the iframe be removed. then i turn back and i seen no iframe

@realamirhe
Copy link
Collaborator

realamirhe commented Oct 13, 2021

Hi, @gamestap99, I didn't get your question well, is it possible to make a code sandbox reproducible one for this own.

Plyr-react destroys plyr package in unmount phase of react component, hence (I guess) this may be something to consider.
The problem might have happened when the component gets unmount but doesn't get re-mounted for props equality or (other react check mechanism), a unique key prop might be helpful in these scenarios.

@realamirhe realamirhe self-assigned this Oct 14, 2021
@realamirhe realamirhe added the bug Something isn't working label Oct 14, 2021
@gamestap99
Copy link
Author

gamestap99 commented Oct 14, 2021

Hi, @gamestap99, I didn't get your question well, is it possible to make a code sandbox reproducible one for this own.

Plyr-react destroys per package in unmount phase of react component, hence (I guess) this may be something to consider. The problem might have happened when the component gets unmount but doesn't get re-mounted for props equality or (other react check mechanism), a unique key prop might be helpful in these scenarios.

Thanks for the reply. I use the package to make hls videos and I put it a tab. When I change to another tab the hls video is destroyed. In devtool,

@gamestap99
Copy link
Author

Hi, @gamestap99, I didn't get your question well, is it possible to make a code sandbox reproducible one for this own.

Plyr-react destroys per package in unmount phase of react component, hence (I guess) this may be something to consider. The problem might have happened when the component gets unmount but doesn't get re-mounted for props equality or (other react check mechanism), a unique key prop might be helpful in these scenarios.

Hey, error occurs when i use setstate. i will close post

@realamirhe
Copy link
Collaborator

Thank you @gamestap99
Could you please test the latest version and give us feedback about the issue you've faced

yarn add git://github.com/chintan9/plyr-react.git#package

@gamestap99
Copy link
Author

Thank you @gamestap99 Could you please test the latest version and give us feedback about the issue you've faced

yarn add git://github.com/chintan9/plyr-react.git#package

Thank you @gamestap99 Could you please test the latest version and give us feedback about the issue you've faced

yarn add git://github.com/chintan9/plyr-react.git#package

well, i will reply you soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants