Skip to content

Provide more appropriate naming for the fourth and fifth arguments of BN #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 20, 2019

Conversation

disktnk
Copy link
Member

@disktnk disktnk commented Jun 20, 2019

took over #184

  • add param-link dict on context, get get owned link
  • handle ndarray directly on additional parameter, avoid to make chainer.Parameter
  • keep link name prefix on batch_normalizaton

@disktnk disktnk added this to the 1.5.0 milestone Jun 20, 2019
@disktnk disktnk changed the title Fix/bn param name [WIP] Provide more appropriate naming for the fourth and fifth arguments of BN Jun 20, 2019
@codecov-io
Copy link

codecov-io commented Jun 20, 2019

Codecov Report

Merging #185 into master will decrease coverage by 0.16%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
- Coverage   89.23%   89.07%   -0.17%     
==========================================
  Files          24       24              
  Lines        1338     1364      +26     
==========================================
+ Hits         1194     1215      +21     
- Misses        144      149       +5
Impacted Files Coverage Δ
onnx_chainer/context.py 97.77% <100%> (+0.55%) ⬆️
onnx_chainer/functions/normalization.py 79.66% <76.47%> (-10.82%) ⬇️
onnx_chainer/export.py 91.01% <0%> (+1.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd8e29a...7711fec. Read the comment docs.

@disktnk disktnk force-pushed the fix/bn-param-name branch from 3e2d7eb to 7711fec Compare June 20, 2019 03:26
@disktnk
Copy link
Member Author

disktnk commented Jun 20, 2019

ChainerUI, test this please

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 7711fec:

@disktnk disktnk changed the title [WIP] Provide more appropriate naming for the fourth and fifth arguments of BN Provide more appropriate naming for the fourth and fifth arguments of BN Jun 20, 2019
@disktnk
Copy link
Member Author

disktnk commented Jun 20, 2019

mean, var are named as :
image

@disktnk
Copy link
Member Author

disktnk commented Jun 20, 2019

This PR lack F.batch_normalization test but I'll deal with it later.

@disktnk disktnk merged commit cf0b98d into chainer:master Jun 20, 2019
@disktnk disktnk deleted the fix/bn-param-name branch June 20, 2019 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants