Provide more appropriate naming for the fourth and fifth arguments of BN #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
==========================================
- Coverage 89.49% 89.18% -0.31%
==========================================
Files 24 24
Lines 1361 1350 -11
==========================================
- Hits 1218 1204 -14
- Misses 143 146 +3
Continue to review full report at Codecov.
|
shinh
reviewed
Jun 20, 2019
onnx_chainer/context.py
Outdated
|
|
||
| To be converted as ONNX tensor. | ||
|
|
||
| Return: |
| @@ -10,34 +10,50 @@ | |||
| @support((1, 6, 7)) | |||
| def convert_BatchNormalization(func, opset_version, input_names, | |||
| output_names, context, parameters): | |||
| names = [context.get_name(v.get_variable().array) for v in func.inputs] | |||
| if names[1].startswith('param_'): | |||
| prefix = names[1][:-6] # remove "_gamma" | |||
There was a problem hiding this comment.
It seems that this part will be entirely changed in #185. I will keep this part as is in this PR.
| if names[1].startswith('param_'): | ||
| prefix = names[1][:-6] # remove "_gamma" | ||
| elif names[2].startswith('param_'): | ||
| prefix = names[2][:-5] # remove "_beta" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad-hoc approach