Improve the naming of values #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinh
approved these changes
Mar 1, 2019
onnx_chainer/context.py
Outdated
| class Context(object): | ||
|
|
||
| def __init__(self, model): | ||
| self.namedparams = dict() |
There was a problem hiding this comment.
How about removing self.namedparams and just use self.name_list even for parameters?
There was a problem hiding this comment.
It sounds reasonable. I would change the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
str(id(v))is used for naming values. This is not human-readable. This PR introduces a new classContext, which can provide a human-readable naming for values. This PR replaces all the occurrences ofstr(id(...))with the call ofContextclass.I expect that
Contextcan contain some additional information such asparameters. This may slightly simplify the interface of implementation.